Skip to content

Update workflow#3901

Merged
shargon merged 4 commits intomasterfrom
update-workflow
Apr 17, 2025
Merged

Update workflow#3901
shargon merged 4 commits intomasterfrom
update-workflow

Conversation

@shargon
Copy link
Member

@shargon shargon commented Apr 17, 2025 •
edited
Loading

Description

  • Update workflow actions

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual testing

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon marked this pull request as ready for review April 17, 2025 07:01
@shargon shargon added Waiting for Review Easy-to-Review a simple edit; just a few lines labels Apr 17, 2025
shargon
shargon commented Apr 17, 2025
View reviewed changes
@Jim8y Jim8y added the NGD Review This pr is an UT/Benchmark PR, NGD can review. label Apr 17, 2025
@shargon
Copy link
Member Author

shargon commented Apr 17, 2025

I'm going to merge it to try to fix #3874, if anyone has any reviews other than Jimmy's, please make them in a new PR

@shargon shargon merged commit 73c11cd into master Apr 17, 2025
7 checks passed
@shargon shargon deleted the update-workflow branch April 17, 2025 08:37
@cschuchardt88
Copy link
Member

cschuchardt88 commented Apr 17, 2025 •
edited
Loading

This isnt going to fix it. The vm is broken. Put a ticket in on github for microsoft.

Jim8y added a commit to Jim8y/neo that referenced this pull request Apr 17, 2025
@Jim8y
Merge branch 'master' into dbft-fuzz
899ba10 
* master:
  DBFTPlugin: include consensus time into block interval (neo-project#3900)
  Isolate unit tests (neo-project#3904)
  Use DateTime.UtcNow (neo-project#3902)
  Update workflow (neo-project#3901)
  optimize: show state more readable (neo-project#3899)
  Optimize KeyedCollectionSlim (neo-project#3877)
  Native: move MillisecondsPerBlock setting to native Policy (neo-project#3895)
  optimize: history command support (neo-project#3892)
  Ensure that view interops can't be changed outside (neo-project#3812)
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @NGDAdmin @cschuchardt88
Update workflow (neo-project#3901)
5881bb6 
* Update workflow

* Update main.yml

* Update .github/workflows/main.yml

---------

Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jim8y Jim8y Jim8y approved these changes

Assignees

No one assigned

Labels

Easy-to-Review a simple edit; just a few lines NGD Review This pr is an UT/Benchmark PR, NGD can review. Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @cschuchardt88 @Jim8y @NGDAdmin