Merged
Conversation
shargon
commented
Apr 4, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Neo/IO/Caching/HashSetCache.cs:97
- The initializer '[]' is not valid syntax for instantiating a List in C#. Please replace it with 'new List<HashSet>()'.
List<HashSet<T>> removeList = [];
16 tasks
Member
Author
|
@neo-project/core ready to review, now it's configurable, and not related to the mempool variable |
shargon
commented
Apr 9, 2025
shargon
commented
Apr 17, 2025
Member
Author
|
Require #3904 |
Member
Author
|
@neo-project/core Workflow fixed, we can review it and test it now |
Jim8y
approved these changes
Apr 17, 2025
vncoelho
approved these changes
Apr 17, 2025
Wi1l-B0t
approved these changes
Apr 17, 2025
5 tasks
cschuchardt88
added a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
* Fix mem usage * Add clear when node disconnect * fix count * Add ut for clear * Add doc an limit also TaskManager * Same as mempool * max * min 100 * Move value to configuration * divide by bucket * use min 1 * Update src/Neo/Network/P2P/RemoteNode.ProtocolHandler.cs * commented out debug.asserted * Revert "commented out debug.asserted" This reverts commit 052841c. * revert to `TargetFrameworks` * Merge branch 'mem-fix-usage' of github.com:neo-project/neo into mem-fix-usage # Conflicts: # src/Neo/Ledger/Blockchain.cs * merge * merge * Update src/Neo/Network/P2P/ChannelsConfig.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Neo/Ledger/Blockchain.cs * Update Blockchain.cs * Update src/Neo/Ledger/Blockchain.cs * Apply suggestions from code review * Update Settings.cs * Update MainService.cs * for see logs * Update main.yml * Update .github/workflows/main.yml * Update main.yml * Update main.yml * Update main.yml * Remove parallel * Update main.yml * Update main.yml * Update main.yml --------- Co-authored-by: Will <201105916+Wi1l-B0t@users.noreply.github.com> Co-authored-by: Jimmy <jinghui@wayne.edu> Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main problem is that we have two
HashSetCacheper remote node connected, every of them use 20_000 entries * 10 buckets, that's means 200_000 entries * 2 = 400_000 entries of 256 bytes, this can reach more 100mb of ram per node connected. I reduce this value from 400_000 entries to 20_000 per node.Require #3904
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: