Skip to content

Use DateTime.UtcNow for time differences#3902

Merged
shargon merged 3 commits intomasterfrom
use-date-utc
Apr 17, 2025
Merged

Use DateTime.UtcNow for time differences#3902
shargon merged 3 commits intomasterfrom
use-date-utc

Conversation

@shargon
Copy link
Member

@shargon shargon commented Apr 17, 2025 •
edited
Loading

Description

Use DateTime.UtcNow for time differences.

Part of the review of #3899

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Manual tests

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shargon shargon changed the title Use DateTime.UtcNow Use DateTime.UtcNow for time differences Apr 17, 2025
@vncoelho
Copy link
Member

vncoelho commented Apr 17, 2025

UTC is slightly faster and makes more sense

@shargon shargon merged commit b868b6b into master Apr 17, 2025
7 checks passed
@shargon shargon deleted the use-date-utc branch April 17, 2025 14:20
Jim8y added a commit to Jim8y/neo that referenced this pull request Apr 17, 2025
@Jim8y
Merge branch 'master' into dbft-fuzz
899ba10 
* master:
  DBFTPlugin: include consensus time into block interval (neo-project#3900)
  Isolate unit tests (neo-project#3904)
  Use DateTime.UtcNow (neo-project#3902)
  Update workflow (neo-project#3901)
  optimize: show state more readable (neo-project#3899)
  Optimize KeyedCollectionSlim (neo-project#3877)
  Native: move MillisecondsPerBlock setting to native Policy (neo-project#3895)
  optimize: history command support (neo-project#3892)
  Ensure that view interops can't be changed outside (neo-project#3812)
cschuchardt88 pushed a commit to cschuchardt88/neo that referenced this pull request Jun 8, 2025
@shargon @cschuchardt88
Use DateTime.UtcNow (neo-project#3902)
31dc18b 
Co-authored-by: Jimmy <jinghui@wayne.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jim8y Jim8y Jim8y approved these changes

@vncoelho vncoelho vncoelho approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees

No one assigned

Labels

Ready to Merge Waiting for Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shargon @vncoelho @Jim8y @Wi1l-B0t