[Optimize]: make show state more maintainable#3899
Merged
NGDAdmin merged 2 commits intoneo-project:masterfrom Apr 17, 2025
Merged
[Optimize]: make show state more maintainable#3899NGDAdmin merged 2 commits intoneo-project:masterfrom
Optimize]: make show state more maintainable#3899NGDAdmin merged 2 commits intoneo-project:masterfrom
Conversation
Optimize[: make show state more readableOptimize[: make show state more maintainable
Optimize[: make show state more maintainableOptimize]: make show state more maintainable
cschuchardt88
previously approved these changes
Apr 15, 2025
Member
|
Conflicts |
vncoelho
reviewed
Apr 16, 2025
372addc to
f710156
Compare
Contributor
Author
fixed |
Contributor
Author
Split this large method into multi smaller and clearer parts |
Jim8y
approved these changes
Apr 17, 2025
shargon
reviewed
Apr 17, 2025
Member
shargon
left a comment
There was a problem hiding this comment.
It's better to use UtcNow for time differences, in my country for example we change the time two times per year, if this happens between it will get incorrect results
shargon
approved these changes
Apr 17, 2025
Member
shargon
left a comment
There was a problem hiding this comment.
But it's ok for me, we can change it later
15 tasks
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Apr 17, 2025
* master: DBFTPlugin: include consensus time into block interval (neo-project#3900) Isolate unit tests (neo-project#3904) Use DateTime.UtcNow (neo-project#3902) Update workflow (neo-project#3901) optimize: show state more readable (neo-project#3899) Optimize KeyedCollectionSlim (neo-project#3877) Native: move MillisecondsPerBlock setting to native Policy (neo-project#3895) optimize: history command support (neo-project#3892) Ensure that view interops can't be changed outside (neo-project#3812)
cschuchardt88
pushed a commit
to cschuchardt88/neo
that referenced
this pull request
Jun 8, 2025
Co-authored-by: Jimmy <jinghui@wayne.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor
show statecommand to make it more readable and maintainable.Type of change
Checklist: