Nullable in Storage classes by shargon · Pull Request #3670 · neo-project/neo

shargon · 2025-01-13T10:41:09Z

Description

Required for #3669

These changes are required for #3669, was found some errors with nullables, and it require to be solved first

Fixes # (issue)

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Current tests

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

shargon · 2025-01-13T10:42:01Z

src/Neo/Persistence/ClonedCache.cs

        protected override void UpdateInternal(StorageKey key, StorageItem value)
        {
-            innerCache.GetAndChange(key).FromReplica(value);
+            _innerCache.GetAndChange(key)?.FromReplica(value);


This fail before, is this expected?

This fail before, is this expected?

I think it should be a bug.

I don't understand why SnapshotCache read from store, but write if the snapshot exists...

Because I want to avoid logic changes in this PR, I will throw a different exception, taking a look to the code it seems that it should always exists or it's a failure

src/Neo/Persistence/DataCache.cs

src/Neo/Persistence/MemorySnapshot.cs

src/Neo/Persistence/MemoryStore.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

…into storage-nullable

src/Neo/Persistence/DataCache.cs

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

src/Neo/Persistence/DataCache.cs

Co-authored-by: nan01ab <yjcc201374@outlook.com>

…into storage-nullable

shargon · 2025-01-17T09:29:54Z

@neo-project/core could you take a look to this one please

cschuchardt88 · 2025-01-19T15:25:47Z

src/Neo/Persistence/DataCache.cs

                if (seek_prefix == null)
                {
-                    throw new ArgumentException();
+                    throw new ArgumentException($"{nameof(key_prefix)} with all bytes being 0xff is not supported now");


Why is all 0xff not support? Then SeekDirection should be only Forward and removed from the parameters of this function.

You need 0xff to go Backward for SeekDirection. ApplicationLogs uses this method. However I used IStore interface to do what this can't do. If you can explain whats the problem. I can fix it.

Why is all 0xff not support? Then SeekDirection should be only Forward and removed from the parameters of this function.

You need 0xff to go Backward for SeekDirection. ApplicationLogs uses this method. However I used IStore interface to do what this can't do. If you can explain whats the problem. I can fix it.

I have a fix, waiting for this PR to merge.

cschuchardt88 · 2025-01-20T05:08:24Z

@nan01ab PR has been merge please add your PR for the 0xff fix. Please don't forget.

* master: (43 commits) Fix `GetAndChange` warnings (neo-project#3702) `Murmur3` should not be cryptographic hash algorithm (neo-project#3668) Test: add tests for native contract id (neo-project#3697) Update nugets (neo-project#3692) [Core P2P] fix the bug (neo-project#3695) Add hardfork HF_Echidna (neo-project#3454) Fix: add lock for RocksDbStore.Snapshot to keep same behavior as MemoryStore and LevelDbStore (neo-project#3689) Nullable rocks db (neo-project#3686) Nullable leveldb (neo-project#3685) Enforcement Compiler Warnings (neo-project#3687) [`Update`] Dotnet & Compiler Version (neo-project#3684) [`Add`]: LevelDB Benchmarks (neo-project#3667) [`Fix`]: Behavior when `keyPrefix` is null in different `IStore.Seek` impls. (neo-project#3682) Improve calculatenetworkfee (neo-project#3674) more 2025 (neo-project#3678) Nullable in Storage classes (neo-project#3670) readonly (neo-project#3676) [Fix] Set max entries for `VerifyProof` in `statePlugin` (neo-project#3675) Neo.json.benchmarks (neo-project#3673) Happy new year 2025 (neo-project#3677) ... # Conflicts: # src/Neo/Neo.csproj # src/Neo/ProtocolSettings.cs # src/Neo/SmartContract/ApplicationEngine.cs # src/Neo/SmartContract/Native/NeoToken.cs # src/Neo/SmartContract/Native/RoleManagement.cs # tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs

Nullable

417cdf2

shargon added the Blocker Issues that are blocking other issues. Check issues details to see what it is blocking. label Jan 13, 2025

shargon commented Jan 13, 2025

View reviewed changes

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

shargon added 4 commits January 13, 2025 11:47

Optimize

354f44f

Fix nullables

114c38c

Fix ut

9a0b4dd

More

281f92a

shargon added the Waiting for Review label Jan 13, 2025

cschuchardt88 reviewed Jan 13, 2025

View reviewed changes

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

src/Neo/Persistence/MemorySnapshot.cs Outdated Show resolved Hide resolved

src/Neo/Persistence/MemoryStore.cs Outdated Show resolved Hide resolved

shargon and others added 7 commits January 13, 2025 13:15

Update src/Neo/Persistence/DataCache.cs

ace1edc

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Update src/Neo/Persistence/MemorySnapshot.cs

ead1cdf

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Update src/Neo/Persistence/MemoryStore.cs

00cec14

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

Remove pragma

ef37d0c

Merge branch 'storage-nullable' of https://github.com/neo-project/neo …

6f139be

…into storage-nullable

Clean

0334489

SnapshotCache

5cd1c53

nan01ab reviewed Jan 13, 2025

View reviewed changes

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

shargon added 3 commits January 13, 2025 15:38

Change exception

d0f034c

Merge branch 'master' into storage-nullable

54afc91

Fix conflicts

2ef6457

cschuchardt88 reviewed Jan 15, 2025

View reviewed changes

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

Update src/Neo/Persistence/DataCache.cs

b5b09a4

Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>

nan01ab reviewed Jan 15, 2025

View reviewed changes

src/Neo/Persistence/DataCache.cs Outdated Show resolved Hide resolved

shargon and others added 5 commits January 15, 2025 07:45

Merge branch 'master' into storage-nullable

174b458

Update src/Neo/Persistence/DataCache.cs

fe56246

Co-authored-by: nan01ab <yjcc201374@outlook.com>

Merge branch 'master' into storage-nullable

3bdae2d

Avoid logic change

5af9001

Merge branch 'storage-nullable' of https://github.com/neo-project/neo …

771ee61

…into storage-nullable

cschuchardt88 and others added 2 commits January 17, 2025 08:46

Merge branch 'master' into storage-nullable

2cd6a79

Merge branch 'master' into storage-nullable

24cf4fb

nan01ab approved these changes Jan 19, 2025

View reviewed changes

cschuchardt88 reviewed Jan 19, 2025

View reviewed changes

shargon merged commit 3d00a60 into master Jan 19, 2025

shargon deleted the storage-nullable branch January 19, 2025 18:35

nan01ab mentioned this pull request Jan 22, 2025

[Improve]: scan operations for IReadOnlyStoreView and fix of Find with all 0xff keyPrefix #3688

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nullable in Storage classes#3670

Nullable in Storage classes#3670
shargon merged 23 commits intomasterfrom
storage-nullable

shargon commented Jan 13, 2025 •

edited

Loading

Uh oh!

shargon Jan 13, 2025

Uh oh!

nan01ab Jan 13, 2025

Uh oh!

shargon Jan 14, 2025

Uh oh!

shargon Jan 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shargon commented Jan 17, 2025

Uh oh!

cschuchardt88 Jan 19, 2025 •

edited

Loading

Uh oh!

nan01ab Jan 19, 2025

Uh oh!

cschuchardt88 commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

shargon commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

shargon Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

nan01ab Jan 13, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Jan 14, 2025

Choose a reason for hiding this comment

Uh oh!

shargon Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shargon commented Jan 17, 2025

Uh oh!

cschuchardt88 Jan 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nan01ab Jan 19, 2025

Choose a reason for hiding this comment

Uh oh!

cschuchardt88 commented Jan 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shargon commented Jan 13, 2025 •

edited

Loading

cschuchardt88 Jan 19, 2025 •

edited

Loading