Conversation
AnnaShaleva
left a comment
There was a problem hiding this comment.
Good, it should work this way. But I'd suggest to process existing chains with this change in order to ensure that cache persisting logic works as expected.
benchmarks/Neo.Benchmarks/Program.cs
Outdated
| BenchmarkRunner.Run<Bechmarks_ReadOnlyStoreView>(); | ||
| BenchmarkRunner.Run<Bechmarks_LevelDB>(); | ||
| BenchmarkRunner.Run<Benchmarks_Cache>(); | ||
| //BenchmarkRunner.Run<Benchmarks_UInt160>(); |
There was a problem hiding this comment.
Why comment out these lines?
There was a problem hiding this comment.
Usually we run only one benchmark, isn't it?
Co-authored-by: nan01ab <yjcc201374@outlook.com>
Co-authored-by: nan01ab <yjcc201374@outlook.com>
|
@shargon conflict please |
|
@cschuchardt88 Failed to unzip file "obj/libleveldb-win-arm64.zip" because the file does not exist or is inaccessible. [TargetFramework=net9.0] |
|
LGTM |
@shargon |
|
@shargon please update this pr accordingly, and lets move on this pr. |
Description
Close #3145
Alternative to #3146
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: