Skip to content

[Update] Dotnet & Compiler Version#3684

Merged
shargon merged 5 commits intoneo-project:masterfrom
cschuchardt88:fix/dotnet-version
Jan 21, 2025
Merged

[Update] Dotnet & Compiler Version#3684
shargon merged 5 commits intoneo-project:masterfrom
cschuchardt88:fix/dotnet-version

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 21, 2025

Change Log

  • Updated Dotnet version and enforced it.
    • note: BigInteger bug fix in version 9.0.102.
  • Changed compiler to latest.

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Changed compiler to latest
Disabled warning in brenchmarks
@cschuchardt88 cschuchardt88 changed the title ['Updates'] Environment Configurations [Updates] Environment Configurations Jan 21, 2025
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschuchardt88 you mix things, you want to update net version do it, style is a different thing

@cschuchardt88 cschuchardt88 changed the title [Updates] Environment Configurations [Update] Dotnet & Compiler Version Jan 21, 2025
@cschuchardt88
Copy link
Member Author

@cschuchardt88 you mix things, you want to update net version do it, style is a different thing

done

@cschuchardt88 cschuchardt88 requested a review from shargon January 21, 2025 10:22
@shargon shargon merged commit fe22fb8 into neo-project:master Jan 21, 2025
@shargon shargon deleted the fix/dotnet-version branch January 21, 2025 11:47
Jim8y added a commit to Jim8y/neo that referenced this pull request Jan 31, 2025
* master: (43 commits)
  Fix `GetAndChange` warnings (neo-project#3702)
  `Murmur3` should not be cryptographic hash algorithm (neo-project#3668)
  Test: add tests for native contract id (neo-project#3697)
  Update nugets (neo-project#3692)
  [Core P2P] fix the bug (neo-project#3695)
  Add hardfork HF_Echidna (neo-project#3454)
  Fix: add lock for RocksDbStore.Snapshot to keep same behavior as MemoryStore and LevelDbStore (neo-project#3689)
  Nullable rocks db (neo-project#3686)
  Nullable leveldb (neo-project#3685)
  Enforcement Compiler Warnings (neo-project#3687)
  [`Update`] Dotnet & Compiler Version (neo-project#3684)
  [`Add`]: LevelDB Benchmarks (neo-project#3667)
  [`Fix`]: Behavior when `keyPrefix` is null in different `IStore.Seek` impls. (neo-project#3682)
  Improve calculatenetworkfee (neo-project#3674)
  more 2025 (neo-project#3678)
  Nullable in Storage classes (neo-project#3670)
  readonly (neo-project#3676)
  [Fix] Set max entries for `VerifyProof` in `statePlugin` (neo-project#3675)
  Neo.json.benchmarks (neo-project#3673)
  Happy new year 2025 (neo-project#3677)
  ...

# Conflicts:
#	src/Neo/Neo.csproj
#	src/Neo/ProtocolSettings.cs
#	src/Neo/SmartContract/ApplicationEngine.cs
#	src/Neo/SmartContract/Native/NeoToken.cs
#	src/Neo/SmartContract/Native/RoleManagement.cs
#	tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants