[Fix]: add lock for RocksDbStore.Snapshot.WriteBatch to keep same behavior#3689
Merged
shargon merged 2 commits intoneo-project:masterfrom Jan 23, 2025
nan01ab:fix.lock-batch-for-rocksdb
Merged
[Fix]: add lock for RocksDbStore.Snapshot.WriteBatch to keep same behavior#3689shargon merged 2 commits intoneo-project:masterfrom nan01ab:fix.lock-batch-for-rocksdb
Fix]: add lock for RocksDbStore.Snapshot.WriteBatch to keep same behavior#3689shargon merged 2 commits intoneo-project:masterfrom
nan01ab:fix.lock-batch-for-rocksdb
Conversation
…ryStore and LevelDbStore
shargon
approved these changes
Jan 22, 2025
cschuchardt88
approved these changes
Jan 22, 2025
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
Jan 31, 2025
* master: (43 commits) Fix `GetAndChange` warnings (neo-project#3702) `Murmur3` should not be cryptographic hash algorithm (neo-project#3668) Test: add tests for native contract id (neo-project#3697) Update nugets (neo-project#3692) [Core P2P] fix the bug (neo-project#3695) Add hardfork HF_Echidna (neo-project#3454) Fix: add lock for RocksDbStore.Snapshot to keep same behavior as MemoryStore and LevelDbStore (neo-project#3689) Nullable rocks db (neo-project#3686) Nullable leveldb (neo-project#3685) Enforcement Compiler Warnings (neo-project#3687) [`Update`] Dotnet & Compiler Version (neo-project#3684) [`Add`]: LevelDB Benchmarks (neo-project#3667) [`Fix`]: Behavior when `keyPrefix` is null in different `IStore.Seek` impls. (neo-project#3682) Improve calculatenetworkfee (neo-project#3674) more 2025 (neo-project#3678) Nullable in Storage classes (neo-project#3670) readonly (neo-project#3676) [Fix] Set max entries for `VerifyProof` in `statePlugin` (neo-project#3675) Neo.json.benchmarks (neo-project#3673) Happy new year 2025 (neo-project#3677) ... # Conflicts: # src/Neo/Neo.csproj # src/Neo/ProtocolSettings.cs # src/Neo/SmartContract/ApplicationEngine.cs # src/Neo/SmartContract/Native/NeoToken.cs # src/Neo/SmartContract/Native/RoleManagement.cs # tests/Neo.UnitTests/SmartContract/Native/UT_NativeContract.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lock for
RocksDbStore.Snapshot.WriteBatchto keep same behavior asMemoryStoreandLevelDbStoreAccording to #3667, lock for
WriteBatchis necessary.If it is necessary, different implementations should be consistent.
Type of change
Checklist: