Skip to content

fix TraverseIterator count#3261

Merged
shargon merged 1 commit intoneo-project:masterfrom
Hecate2:patch-1
May 22, 2024
Merged

fix TraverseIterator count#3261
shargon merged 1 commit intoneo-project:masterfrom
Hecate2:patch-1

Conversation

@Hecate2
Copy link
Contributor

@Hecate2 Hecate2 commented May 22, 2024

Description

It seems we should limit the count of iterator items <= settings.MaxIteratorResultItems, instead of >

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

No test has been carried out.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Hecate2
Copy link
Contributor Author

Hecate2 commented May 22, 2024

Thanks to https://discord.com/channels/382937847893590016/382938783563382784/1242729779753648178 for discovering the bug

@shargon shargon added the Bug Used to tag confirmed bugs label May 22, 2024
@shargon
Copy link
Member

shargon commented May 22, 2024

Merged without coverage because it's a bug

@shargon shargon merged commit 2db4a17 into neo-project:master May 22, 2024
@vncoelho
Copy link
Member

vncoelho commented May 22, 2024

Merged without coverage because it's a bug

Could not wait 24-48-72 hours?

@vncoelho
Copy link
Member

vncoelho commented May 22, 2024

Are you running master branch for a mainnet application? @shargon
Please, respect the @neo-project/core colleagues. We have already discussed that PLENTY of times

@shargon
Copy link
Member

shargon commented May 22, 2024

Are you running master branch for a mainnet application? @shargon Please, respect the @neo-project/core colleagues. We have already discussed that PLENTY of times

@superboyiii require this change and it's a bug, we need to apply this patch asap

@Jim8y
Copy link
Contributor

Jim8y commented May 22, 2024

Merged without coverage because it's a bug

Could not wait 24-48-72 hours?

Pal, my bad, this one is a bug fix, need to update the node right away.

@shargon
Copy link
Member

shargon commented May 22, 2024

Also #3263

@cschuchardt88
Copy link
Member

cschuchardt88 commented May 23, 2024

@vncoelho @shargon @Jim8y

We all agreed that 12 hours is good enough for a wait on a merge. I think merging for bug fixes 12 hours is good enough. All other PRs should be merged on a Friday or Monday. Because with all the other merging going on can have bugs in them as well. This way we can push bug fixes ASAP without having to face other bugs brought in.

Jim8y added a commit to Jim8y/neo that referenced this pull request May 25, 2024
@Jim8y
Merge branch 'latest-plugins' of github.com:Jim8y/neo into latest-plu…
4a96d1e 
…gins

* 'latest-plugins' of github.com:Jim8y/neo: (21 commits)
  fix: custom plugins won't shown by command `plugins` (neo-project#3269)
  COVERALL: Improve maintenance and readbility of some variables (neo-project#3248)
  Update nuget (neo-project#3262)
  [**Part-2**] Neo module/master fixes (neo-project#3244)
  Fix `dotnet pack` error (neo-project#3266)
  Fix and Update devcontainer.json to use Dockerfile  (neo-project#3259)
  Add optimization to template (neo-project#3247)
  Optimize plugin's models (neo-project#3246)
  fix CancelTransaction !signers.Any() (neo-project#3263)
  COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252)
  fix TraverseIterator count (neo-project#3261)
  Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245)
  [**Part-1**] `neo-module/master` (neo-project#3232)
  Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243)
  improve parse method in neo-cli (neo-project#3204)
  Fix neo-project#3239 (neo-project#3242)
  Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240)
  v3.7.4 (neo-project#3237)
  fix hardfork issues (neo-project#3234)
  Update src/Neo.CLI/CLI/MainService.Plugins.cs
  ...

# Conflicts:
#	src/Neo.CLI/CLI/MainService.Plugins.cs
@superboyiii superboyiii mentioned this pull request Jun 11, 2024
Closed
6 tasks
superboyiii added a commit to neo-project/neo-modules that referenced this pull request Jun 11, 2024
@superboyiii
fix patch from:
19813f5 
neo-project/neo#3261
and
neo-project/neo#3299
@Jim8y Jim8y modified the milestone: v3.7.5 Jun 11, 2024
superboyiii added a commit to neo-project/neo-modules that referenced this pull request Jun 12, 2024
@superboyiii
v3.7.5 (#913)
8c6b64b 
* fix patch from:
neo-project/neo#3261
and
neo-project/neo#3299

* add neo-project/neo#3282

* add neo-project/neo#3263

* v3.7.5 hotfix

* readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

@Jim8y Jim8y Jim8y approved these changes

Assignees

No one assigned

Labels

Bug Used to tag confirmed bugs

Projects

None yet

Milestone

v3.7.5

Development

Successfully merging this pull request may close these issues.

5 participants

@Hecate2 @shargon @vncoelho @Jim8y @cschuchardt88