COVERALL: Improve maintenance and readbility of some variables#3248
Merged
COVERALL: Improve maintenance and readbility of some variables#3248
Conversation
Contributor
|
LGTM |
Jim8y
previously approved these changes
May 21, 2024
Member
Author
|
I think there is some error introduced @Jim8y [coverlet] MergeWith: file ''/home/runner/work/neo/neo/TestResults/coverage/coverage.json'' does not exist.
Generating report '/home/runner/work/neo/neo/tests/Neo.Plugins.Storage.Tests/'/home/runner/work/neo/neo/TestResults/coverage/'.info'I just checked here on the report. |
Member
|
still not working |
shargon
reviewed
May 21, 2024
Member
shargon
left a comment
There was a problem hiding this comment.
I prefer to fix the issue instead of change the style (or both together)
Member
Author
You can try the fix in another PR. |
Contributor
I compared the string,,,,, they are the same.... not sure whats wrong |
shargon
requested changes
May 21, 2024
Member
Author
After the fix I will test this PR again and make sure it is working. |
cschuchardt88
previously requested changes
May 22, 2024
Member
Author
|
@cschuchardt88, sure! I will try with git-env. I will reopen after the fix. |
shargon
approved these changes
May 22, 2024
Jim8y
approved these changes
May 23, 2024
cschuchardt88
approved these changes
May 23, 2024
Jim8y
added a commit
to Jim8y/neo
that referenced
this pull request
May 25, 2024
…gins * 'latest-plugins' of github.com:Jim8y/neo: (21 commits) fix: custom plugins won't shown by command `plugins` (neo-project#3269) COVERALL: Improve maintenance and readbility of some variables (neo-project#3248) Update nuget (neo-project#3262) [**Part-2**] Neo module/master fixes (neo-project#3244) Fix `dotnet pack` error (neo-project#3266) Fix and Update devcontainer.json to use Dockerfile (neo-project#3259) Add optimization to template (neo-project#3247) Optimize plugin's models (neo-project#3246) fix CancelTransaction !signers.Any() (neo-project#3263) COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252) fix TraverseIterator count (neo-project#3261) Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245) [**Part-1**] `neo-module/master` (neo-project#3232) Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243) improve parse method in neo-cli (neo-project#3204) Fix neo-project#3239 (neo-project#3242) Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240) v3.7.4 (neo-project#3237) fix hardfork issues (neo-project#3234) Update src/Neo.CLI/CLI/MainService.Plugins.cs ... # Conflicts: # src/Neo.CLI/CLI/MainService.Plugins.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.