COVERALL: fix broken by changing report from lcov to cobertura#3252
COVERALL: fix broken by changing report from lcov to cobertura#3252
Conversation
|
@neo-project/core , fell free to make any change here if you see that the lastest test is still failing. My first commit is just to print the report last file. |
|
Does it run correctly on Draft PRs? |
|
|
|
The last data we have is "76.122%", |
|
@cschuchardt88, the migration also increased coverage of neo-modules a little
|
|
|
|
Lcov support namespaces I think, is not supported now by Coveralls? |
I do know the reason why it stopped working. |
|
|
.github/workflows/main.yml
Outdated
| - name: Coveralls | ||
| if: matrix.os == 'ubuntu-latest' | ||
| uses: coverallsapp/github-action@v2.2.3 |
There was a problem hiding this comment.
Update the version to the with the latest, is not needed two pr for this
There was a problem hiding this comment.
I will not update it here, @shargon, it can cause other problems. I will wait until it is fixed and the problem is not persistant
There was a problem hiding this comment.
fell free to approve or open another PR
There was a problem hiding this comment.
as you said in the other PR, the upgrade in version did not solve the problem, right?
There was a problem hiding this comment.
3 pr for coverals is not required, is one pr per line changed, obviously unnecessary
you wait for response from the team that makes the plugin lemurheavy/coveralls-public#1762 |
It must be a different thing, in dev-pack it works, and I remember that we used lcov because is dotnet prepared, it accept namespaces and assemblies. |
|
@Jim8y the main problem is not the format, in dev pack it works with lcov |
|
@shargon ,forget the other PRs and focus on the fix. |
Try to re-run previous commits of this repo and check results. |
|
|
|
I am re-running for improve parse method in neo-cli (#3204) #8447
|
|
|
|
@cschuchardt88, as can be seen, even old commits that were success will now fail. I think this should be merged asap and later moved back to lcov if start to work again. |
It's a review. And please, don't blame me for to the same as you did before me #3155 (comment) , and not during review time, during proofs |
|
Very good, That time we were talking on discord and trying to figure out this. Then out of nowhere, you freaked out about changing the draft together. I will not wash dirty clothes here, @shargon. |
…gins * 'latest-plugins' of github.com:Jim8y/neo: (21 commits) fix: custom plugins won't shown by command `plugins` (neo-project#3269) COVERALL: Improve maintenance and readbility of some variables (neo-project#3248) Update nuget (neo-project#3262) [**Part-2**] Neo module/master fixes (neo-project#3244) Fix `dotnet pack` error (neo-project#3266) Fix and Update devcontainer.json to use Dockerfile (neo-project#3259) Add optimization to template (neo-project#3247) Optimize plugin's models (neo-project#3246) fix CancelTransaction !signers.Any() (neo-project#3263) COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252) fix TraverseIterator count (neo-project#3261) Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245) [**Part-1**] `neo-module/master` (neo-project#3232) Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243) improve parse method in neo-cli (neo-project#3204) Fix neo-project#3239 (neo-project#3242) Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240) v3.7.4 (neo-project#3237) fix hardfork issues (neo-project#3234) Update src/Neo.CLI/CLI/MainService.Plugins.cs ... # Conflicts: # src/Neo.CLI/CLI/MainService.Plugins.cs
close #3250