Skip to content

[**Part-2**] Neo module/master fixes#3244

Merged
shargon merged 43 commits intoneo-project:masterfrom
cschuchardt88:neo-module/master-fixes
May 22, 2024
Merged

[**Part-2**] Neo module/master fixes#3244
shargon merged 43 commits intoneo-project:masterfrom
cschuchardt88:neo-module/master-fixes

Conversation

@cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented May 20, 2024

Change Log

  • Fixed config.json
  • Renamed config.json to $PluginName.json

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

cschuchardt88 and others added 30 commits May 13, 2024 22:04
@cschuchardt88
Moved neo-modules to neo
40614dd
@cschuchardt88
Configured module projects
b1bad7c
@cschuchardt88
Configured Test Projects
69c8ded
@cschuchardt88
Dotnet format
5ffd0b1
@cschuchardt88
Update github workflow for tests
143db61
@cschuchardt88
removed dupes in .editorconfig
fc17bed
@cschuchardt88
remove dupe file
c66a438
@cschuchardt88
Fixed waarning
d185b7a
@cschuchardt88
fixed macOS workflow for leveldb
0453f0a
@cschuchardt88
Added EXCLUDED_TESTS for Neo.Plugins.Storage on macOS and `Wind…
4e9f0d8 
…ows`
@cschuchardt88
Fixed workflow tests for windows
483c831
@cschuchardt88
Fixed char ecsape for tests on windows
3902acf
@cschuchardt88
Fixed tests
e354cbd
@cschuchardt88
Fixed tests
71105dd
@shargon
Apply suggestions from code review
e13b8a2 
Not related to the PR
@shargon
Apply suggestions from code review
79fe63f
@cschuchardt88
Update .editorconfig
f80b145
@cschuchardt88
Update .editorconfig
3289c9c
@cschuchardt88
Changed for @vncoelho request
9e3017b
@cschuchardt88
Merge branch 'neo-module/master' of https://github.com/cschuchardt88/neo
cac59ae 
 into neo-module/master
@cschuchardt88
Merge branch 'master' into neo-module/master
5871878
@cschuchardt88
Added @vncoelho changes
d8fc1c4
@cschuchardt88
Merge branch 'neo-module/master' of https://github.com/cschuchardt88/neo
b728ef3 
 into neo-module/master
@cschuchardt88
Moved RpcClient to src\plugins
cb014ff
@cschuchardt88
fixed rpc tests
2144e0b
@shargon
Merge branch 'master' into neo-module/master
19502d9
@cschuchardt88 @shargon
Update .github/workflows/main.yml
4db6165 
Co-authored-by: Shargon <shargon@gmail.com>
@cschuchardt88
Update .github/workflows/main.yml
81ad31a
@cschuchardt88
Update .github/workflows/main.yml
68e4146
@cschuchardt88
Plugin fixes for configuration files
a50cf5a
vncoelho
vncoelho previously approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was initially tested with this PR.

@AnnaShaleva AnnaShaleva mentioned this pull request May 21, 2024
Closed
shargon
shargon reviewed May 21, 2024
View reviewed changes
AnnaShaleva
AnnaShaleva reviewed May 21, 2024
View reviewed changes
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the following fact: new PluginName.json configuration files are added in this PR, but you haven't removed the corresponding old config.json configuration files.

@vncoelho
Copy link
Member

vncoelho commented May 22, 2024

I'm wondering about the following fact: new PluginName.json configuration files are added in this PR, but you haven't removed the corresponding old config.json configuration files.

Old config are for neo-cli now

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented May 22, 2024

I'm wondering about the following fact: new PluginName.json configuration files are added in this PR, but you haven't removed the corresponding old config.json configuration files.

Old config are for neo-cli now

They needed to be deleted, Not neo-cli but the plugin old config.json files

@vncoelho
Copy link
Member

vncoelho commented May 22, 2024

I'm wondering about the following fact: new PluginName.json configuration files are added in this PR, but you haven't removed the corresponding old config.json configuration files.

Now I saw that the files were there...ahahah

Jim8y
Jim8y previously approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Jim8y Jim8y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major changes. LGTM

vncoelho
vncoelho previously approved these changes May 22, 2024
View reviewed changes
@vncoelho vncoelho requested a review from shargon May 22, 2024 14:27
@vncoelho
Copy link
Member

vncoelho commented May 22, 2024

@NGDAdmin , this is urgent. Currently master is broken without this.

@shargon shargon dismissed stale reviews from vncoelho and Jim8y via 81aba7e May 22, 2024 17:00
@shargon shargon merged commit 6c267fb into neo-project:master May 22, 2024
@shargon shargon deleted the neo-module/master-fixes branch May 22, 2024 20:36
Jim8y added a commit to Jim8y/neo that referenced this pull request May 25, 2024
@Jim8y
Merge branch 'latest-plugins' of github.com:Jim8y/neo into latest-plu…
4a96d1e 
…gins

* 'latest-plugins' of github.com:Jim8y/neo: (21 commits)
  fix: custom plugins won't shown by command `plugins` (neo-project#3269)
  COVERALL: Improve maintenance and readbility of some variables (neo-project#3248)
  Update nuget (neo-project#3262)
  [**Part-2**] Neo module/master fixes (neo-project#3244)
  Fix `dotnet pack` error (neo-project#3266)
  Fix and Update devcontainer.json to use Dockerfile  (neo-project#3259)
  Add optimization to template (neo-project#3247)
  Optimize plugin's models (neo-project#3246)
  fix CancelTransaction !signers.Any() (neo-project#3263)
  COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252)
  fix TraverseIterator count (neo-project#3261)
  Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245)
  [**Part-1**] `neo-module/master` (neo-project#3232)
  Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243)
  improve parse method in neo-cli (neo-project#3204)
  Fix neo-project#3239 (neo-project#3242)
  Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240)
  v3.7.4 (neo-project#3237)
  fix hardfork issues (neo-project#3234)
  Update src/Neo.CLI/CLI/MainService.Plugins.cs
  ...

# Conflicts:
#	src/Neo.CLI/CLI/MainService.Plugins.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

@shargon shargon shargon approved these changes

@vncoelho vncoelho vncoelho approved these changes

@Jim8y Jim8y Jim8y left review comments

Assignees

No one assigned

Labels

Ready to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cschuchardt88 @vncoelho @shargon @Jim8y @AnnaShaleva