Fix Widevine by properly listening to widevine-... events, and update docs (fix #1153) by TheCleric · Pull Request #1164 · nativefier/nativefier

TheCleric · 2021-04-28T16:35:31Z

As documented in #1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed.

This PR adds the events, and as well adds better documentation on the signing limitation.

This may also help resolve #1147

ronjouch · 2021-04-29T01:20:39Z

@TheCleric I merged your doc with mine added minutes ago before I saw this PR.

ronjouch

@TheCleric two micro-nits, then feel free to merge

ronjouch · 2021-04-29T01:38:27Z

 # https://docs.npmjs.com/misc/faq#should-i-check-my-node-modules-folder-into-git
 node_modules
+# Python virtual environment in case it's created for the Castlabs code signing tool
+venv


ronjouch · 2021-04-29T01:42:38Z

-            mainWindow.webContents.sendInputEvent(inputEvent);
-          });
+  if (appArgs.widevine !== undefined) {
+    // @ts-ignore


Here and below: I like to comment why @ts-ignore is used when it is. Pls inline comment each of these. TSC is fine with it. For example,

Suggested change

// @ts-ignore

// @ts-ignore because blah blah blah. Alternative is to foo, but we prefer bar.

ronjouch · 2021-04-29T01:46:59Z

+  }
+}
+
+function ready(): void {


Suggested change

function ready(): void {

function onReady(): void {

for consistency with our other similar event handlers?

… docs (fix nativefier#1153) (PR nativefier#1164) As documented in nativefier#1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve nativefier#1147

* Add ability to inject multiple css/js files * API doc: Move misplaced macOS shortcuts doc (PR #1158) When I added this documentation originally, I guess I placed it in the wrong location. * README: use quotes in example, to divert users from shell globbing pitfalls Follow-up of #1159 (comment) * Support opening URLs passed as arg to Nativefied application (fix #405) (PR #1154) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * macOS: Fix crash when using --tray (fix #527), and invisible icon (fix #942, fix #668) (#1156) This fixes: 1. A startup crash on macOS when using the `--tray` option; see #527. ![image](https://user-images.githubusercontent.com/22625791/115987741-99544600-a5b6-11eb-866a-dadb5640eecb.png) 2. Invisible tray icon on macOS; see #942 and #668. ![image](https://user-images.githubusercontent.com/22625791/115988276-24364000-a5b9-11eb-80c3-561a8a646754.png) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * API.md / --widevine: document signing apps to make some sites like HBO Max & Udemy work (fix #1147) * Prompt to confirm when page is attempting to prevent unload (#1163) Should alleviate part of the issue in #1151 * Add an option to upgrade an existing app (fix #1131) (PR #1138) This adds a `--upgrade` option to upgrade-in-place an old app, re-using its options it can. Should help fix #1131 Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * Bump to Electron 12.0.5 with Chrome 89.0.4389.128 * Add newly discovered Google internal login page (#1167) * Fix Widevine by properly listening to widevine-... events, and update docs (fix #1153) (PR #1164) As documented in #1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve #1147 * Improve suffix creation + tests * API: clarif in existing doc by the way * Typo Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> Co-authored-by: Ben Curtis <github@nosolutions.com> Co-authored-by: Fabian Wolf <22625791+fabiwlf@users.noreply.github.com>

… docs (fix nativefier#1153) (PR nativefier#1164) As documented in nativefier#1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve nativefier#1147

…1170)

…1162) * Add ability to inject multiple css/js files * API doc: Move misplaced macOS shortcuts doc (PR nativefier#1158) When I added this documentation originally, I guess I placed it in the wrong location. * README: use quotes in example, to divert users from shell globbing pitfalls Follow-up of nativefier#1159 (comment) * Support opening URLs passed as arg to Nativefied application (fix nativefier#405) (PR nativefier#1154) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * macOS: Fix crash when using --tray (fix nativefier#527), and invisible icon (fix nativefier#942, fix nativefier#668) (nativefier#1156) This fixes: 1. A startup crash on macOS when using the `--tray` option; see nativefier#527. ![image](https://user-images.githubusercontent.com/22625791/115987741-99544600-a5b6-11eb-866a-dadb5640eecb.png) 2. Invisible tray icon on macOS; see nativefier#942 and nativefier#668. ![image](https://user-images.githubusercontent.com/22625791/115988276-24364000-a5b9-11eb-80c3-561a8a646754.png) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * API.md / --widevine: document signing apps to make some sites like HBO Max & Udemy work (fix nativefier#1147) * Prompt to confirm when page is attempting to prevent unload (nativefier#1163) Should alleviate part of the issue in nativefier#1151 * Add an option to upgrade an existing app (fix nativefier#1131) (PR nativefier#1138) This adds a `--upgrade` option to upgrade-in-place an old app, re-using its options it can. Should help fix nativefier#1131 Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * Bump to Electron 12.0.5 with Chrome 89.0.4389.128 * Add newly discovered Google internal login page (nativefier#1167) * Fix Widevine by properly listening to widevine-... events, and update docs (fix nativefier#1153) (PR nativefier#1164) As documented in nativefier#1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve nativefier#1147 * Improve suffix creation + tests * API: clarif in existing doc by the way * Typo Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> Co-authored-by: Ben Curtis <github@nosolutions.com> Co-authored-by: Fabian Wolf <22625791+fabiwlf@users.noreply.github.com>

TheCleric and others added 5 commits April 27, 2021 18:27

Add widevine specific events when using widevine

7722963

Ignore venv (for having a python virtual env for Castlabs EVS)

826f357

Add Castlabs EVS infor to Widevine documentation

cda75bb

Add comment for venv ignore

416bb5c

Merge branch 'master' into fix/widevine-events-and-docs

0e5c149

ronjouch changed the title ~~Listen for widevine events + update docs~~ Fix Widevine by properly listening to widevine-... events, and update docs (fix #1153) Apr 29, 2021

ronjouch approved these changes Apr 29, 2021

View reviewed changes

TheCleric added 3 commits April 29, 2021 13:01

Merge branch 'master' into fix/widevine-events-and-docs

2bada8b

Add ts-ignore reasonings

fd284ff

ready -> onReady

05f1464

ronjouch merged commit f6e1ebd into nativefier:master Apr 29, 2021

TheCleric deleted the fix/widevine-events-and-docs branch April 29, 2021 17:55

ronjouch added a commit that referenced this pull request Apr 30, 2021

Fix app not starting since widevine PR / #1164

1549124

TheCleric pushed a commit that referenced this pull request Apr 30, 2021

Fix app not starting since widevine PR / #1164 (#1170)

c4356e4

Adam777Z pushed a commit to Adam777Z/nativefier that referenced this pull request Nov 9, 2022

Fix app not starting since widevine PR / nativefier#1164 (nativefier#…

c083a90

…1170)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Widevine by properly listening to widevine-... events, and update docs (fix #1153)#1164

Fix Widevine by properly listening to widevine-... events, and update docs (fix #1153)#1164
ronjouch merged 8 commits into
nativefier:masterfrom
TheCleric:fix/widevine-events-and-docs

TheCleric commented Apr 28, 2021

Uh oh!

ronjouch commented Apr 29, 2021 •

edited

Loading

Uh oh!

ronjouch left a comment

Uh oh!

ronjouch Apr 29, 2021

Uh oh!

ronjouch Apr 29, 2021

Uh oh!

ronjouch Apr 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// @ts-ignore
	// @ts-ignore because blah blah blah. Alternative is to foo, but we prefer bar.

Uh oh!

Conversation

TheCleric commented Apr 28, 2021

Uh oh!

ronjouch commented Apr 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronjouch left a comment

Choose a reason for hiding this comment

Uh oh!

ronjouch Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

ronjouch Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

ronjouch Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ronjouch commented Apr 29, 2021 •

edited

Loading