This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Fix app not starting since widevine PR / #1164#1170
Merged
Conversation
ronjouch
commented
Apr 30, 2021
| } | ||
| }); | ||
|
|
||
| if (appArgs.widevine !== undefined) { |
Contributor
Author
There was a problem hiding this comment.
This condition was excessive in a normal (non-widevine) build. In a normal build, appArgs.widevine is false (which is !== undefined). So, this widevine branch was taken even in a non-widevine build, and since widevine-ready isn't called here, onReady was never called and the main window was never created.
Contributor
Author
There was a problem hiding this comment.
@TheCleric asking for a PR to be sure this is the fix you'd expect, or if instead your preferred fix is to avoid appArgs.widevine being false at this point. Feel free to push to my PR branch if you have more/different changes to do
Collaborator
There was a problem hiding this comment.
Nope looks good to me. Sorry for the bug!
TheCleric
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression in f6e1ebd .
Also, fixing a typo I missed in the PR, and adding types for callback params.