This repository was archived by the owner on Sep 29, 2023. It is now read-only.
Fix injecting multiple css/js files (fix #458)#1162
Merged
Conversation
ronjouch
reviewed
Apr 29, 2021
When I added this documentation originally, I guess I placed it in the wrong location.
…ivefier#405) (PR nativefier#1154) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
…e icon (fix nativefier#942, fix nativefier#668) (nativefier#1156) This fixes: 1. A startup crash on macOS when using the `--tray` option; see nativefier#527.  2. Invisible tray icon on macOS; see nativefier#942 and nativefier#668.  Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
…O Max & Udemy work (fix nativefier#1147)
…er#1163) Should alleviate part of the issue in nativefier#1151
…tivefier#1138) This adds a `--upgrade` option to upgrade-in-place an old app, re-using its options it can. Should help fix nativefier#1131 Co-authored-by: Ronan Jouchet <ronan@jouchet.fr>
… docs (fix nativefier#1153) (PR nativefier#1164) As documented in nativefier#1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve nativefier#1147
8b3d803 to
92b9e83
Compare
Collaborator
Author
|
@ronjouch take a look and make sure I addressed your concerns please. |
ronjouch
approved these changes
Apr 30, 2021
| const postFixHash = hash.digest('hex').substring(0, 6); | ||
| function normalizeAppName(appName: string): string { | ||
| // use a simple random string to prevent collision | ||
| const postFixHash = generateRandomSuffix(); |
Contributor
There was a problem hiding this comment.
By the way, I see you commented on an issue about this hash/suffix. This is related to #888 . Is the reason for this hash clear to you, and do you think we should keep doing it?
Collaborator
Author
There was a problem hiding this comment.
It is clear to me, and I do think we should keep doing it. I do not see the harm in it as long as we reference the app name correctly (i.e., user provided/inferred) where appropriate instead of this internal one.
| }); | ||
| }); | ||
|
|
||
| describe('generateRandomSuffix', () => { |
4 tasks
ronjouch
added a commit
that referenced
this pull request
May 3, 2021
) This is a follow-up of #1162 (comment) PR #1162 introduced a new `generateRandomSuffix` helper function, used it for its needs (avoiding collisions of injected js/css). But it also replaced existing appname normalizing logic with it, introducing randomness in a place that used to be deterministic. As a result, starting with dd6e15f / v43.1.0, re-creating an app would cause the app to use a different appName, thus a different appData folder, thus losing user data including cookies. This PR leaves the `--inject` fixes of #1176, but reverts the appName logic to the pre-#1176 code.
ronjouch
added a commit
that referenced
this pull request
May 3, 2021
) (PR #1179) This is a follow-up of #1162 (comment) PR #1162 introduced a new `generateRandomSuffix` helper function, used it for its needs (avoiding collisions of injected js/css). But it also replaced existing appname normalizing logic with it, introducing randomness in a place that used to be deterministic. As a result, starting with dd6e15f / v43.1.0, re-creating an app would cause the app to use a different appName, thus a different appData folder, thus losing user data including cookies. This PR leaves the `--inject` fixes of #1176, but reverts the appName logic to the pre-#1176 code.
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…1162) * Add ability to inject multiple css/js files * API doc: Move misplaced macOS shortcuts doc (PR nativefier#1158) When I added this documentation originally, I guess I placed it in the wrong location. * README: use quotes in example, to divert users from shell globbing pitfalls Follow-up of nativefier#1159 (comment) * Support opening URLs passed as arg to Nativefied application (fix nativefier#405) (PR nativefier#1154) Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * macOS: Fix crash when using --tray (fix nativefier#527), and invisible icon (fix nativefier#942, fix nativefier#668) (nativefier#1156) This fixes: 1. A startup crash on macOS when using the `--tray` option; see nativefier#527.  2. Invisible tray icon on macOS; see nativefier#942 and nativefier#668.  Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * API.md / --widevine: document signing apps to make some sites like HBO Max & Udemy work (fix nativefier#1147) * Prompt to confirm when page is attempting to prevent unload (nativefier#1163) Should alleviate part of the issue in nativefier#1151 * Add an option to upgrade an existing app (fix nativefier#1131) (PR nativefier#1138) This adds a `--upgrade` option to upgrade-in-place an old app, re-using its options it can. Should help fix nativefier#1131 Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> * Bump to Electron 12.0.5 with Chrome 89.0.4389.128 * Add newly discovered Google internal login page (nativefier#1167) * Fix Widevine by properly listening to widevine-... events, and update docs (fix nativefier#1153) (PR nativefier#1164) As documented in nativefier#1153, for Widevine support to work properly, we need to listen for the Widevine ready event, and as well for certain sites the app must be signed. This PR adds the events, and as well adds better documentation on the signing limitation. This may also help resolve nativefier#1147 * Improve suffix creation + tests * API: clarif in existing doc by the way * Typo Co-authored-by: Ronan Jouchet <ronan@jouchet.fr> Co-authored-by: Ben Curtis <github@nosolutions.com> Co-authored-by: Fabian Wolf <22625791+fabiwlf@users.noreply.github.com>
Adam777Z
pushed a commit
to Adam777Z/nativefier
that referenced
this pull request
Nov 9, 2022
…tivefier#1176) (PR nativefier#1179) This is a follow-up of nativefier#1162 (comment) PR nativefier#1162 introduced a new `generateRandomSuffix` helper function, used it for its needs (avoiding collisions of injected js/css). But it also replaced existing appname normalizing logic with it, introducing randomness in a place that used to be deterministic. As a result, starting with 0e58f8e / v43.1.0, re-creating an app would cause the app to use a different appName, thus a different appData folder, thus losing user data including cookies. This PR leaves the `--inject` fixes of nativefier#1176, but reverts the appName logic to the pre-nativefier#1176 code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458