This repository was archived by the owner on Sep 29, 2023. It is now read-only.
app name nativefier-postFixHash#888
Closed
0xnu wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Finbarrs Oketunji <oketunjifinbarrs@gmail.com>
|
I opened a PR on this one too. #892 |
Signed-off-by: Finbarrs Oketunji <oketunjifinbarrs@gmail.com>
mark-carlson
reviewed
Jan 9, 2020
Signed-off-by: Finbarrs Oketunji <oketunjifinbarrs@gmail.com>
ronjouch
suggested changes
Jan 14, 2020
Collaborator
|
@0xnu I think we may have gotten this resolved since you submitted the PR. Can you verify, and if you still feel like it's worth pursuing, get master merged into this branch so we can take a look again? |
Collaborator
|
Closing this as the issue it references no longer seems to be a problem, and as well this branch would need cleanup. @0xnu if you still see a use case for the code you have here, please get the conflicts resolved and let us know what the PR would achieve at this point. We'd still be happy to take a look at it. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #851