Skip to content

Prevent layer controls buttons changing layout while taking screenshots with flash effect on#6194

Merged
brisvag merged 3 commits intonapari:mainfrom
dalthviz:issue_6147
Sep 4, 2023
Merged

Prevent layer controls buttons changing layout while taking screenshots with flash effect on#6194
brisvag merged 3 commits intonapari:mainfrom
dalthviz:issue_6147

Conversation

@dalthviz
Copy link
Copy Markdown
Member

@dalthviz dalthviz commented Aug 28, 2023

References and relevant issues

Closes #6147

Description

Prevent showing the layer controls buttons with a displaced layout while using Save Screenshot with the Viewer:

Before:

current_controls_flash_buttons

After:

fix_controls_flash_buttons

@github-actions github-actions bot added the qt Relates to qt label Aug 28, 2023
@dalthviz dalthviz added bugfix PR with bugfix UI/UX labels Aug 28, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6194 (577279c) into main (55b9a97) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6194      +/-   ##
==========================================
+ Coverage   91.63%   91.67%   +0.04%     
==========================================
  Files         582      582              
  Lines       51079    51080       +1     
==========================================
+ Hits        46805    46829      +24     
+ Misses       4274     4251      -23     
Files Changed Coverage Δ
napari/_qt/utils.py 79.31% <100.00%> (+0.14%) ⬆️

... and 6 files with indirect coverage changes

@Czaki Czaki added this to the 0.4.19 milestone Aug 28, 2023
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 28, 2023
@brisvag
Copy link
Copy Markdown
Contributor

brisvag commented Aug 29, 2023

What a bizarre bug 😆

@brisvag brisvag merged commit 3ced203 into napari:main Sep 4, 2023
@melonora melonora removed the ready to merge Last chance for comments! Will be merged in ~24h label Sep 14, 2023
kne42 added a commit to kne42/napari that referenced this pull request Sep 19, 2023
* main: (26 commits)
  Fix some typing in napari.components (napari#6203)
  Use class name for object that does not have qt name (napari#6222)
  test: [Automatic] Constraints upgrades: `hypothesis`, `magicgui`, `psygnal`, `tensorstore`, `tifffile`, `tqdm`, `virtualenv` (napari#6143)
  Replace more np.all( ... = ...) with np.array_equal (napari#6213)
  remove np.all(... == ...) in test_surface.py (napari#6218)
  Ensure pandas Series is initialized with a list as data (napari#6226)
  Stop using temporary directory for store array for paint test (napari#6191)
  Bugfix: ensure thumbnail represents canvas when multiscale (napari#6200)
  cleanup np.all(... == ...) from test_points.py (napari#6217)
  [pre-commit.ci] pre-commit autoupdate (napari#6221)
  use app-model for file menu (napari#4865)
  Add tests to cover slicing behavior when changing layers and data (napari#4819)
  [pre-commit.ci] pre-commit autoupdate (napari#6128)
  Add test coverage for async slicing of labels (napari#5325)
  Add collision check when set colors for labels layer (napari#6193)
  Update "toggle ndview" text (napari#6192)
  Prevent layer controls buttons changing layout while taking screenshots with flash effect on (napari#6194)
  Fix typing in napari.utils.perf (napari#6132)
  Add GUI test coverage for changes to Labels.show_selected_label (napari#5372)
  Fix types in 'napari.utils.colormaps.categorical_colormap' (napari#6154)
  ...
Czaki pushed a commit that referenced this pull request Oct 17, 2023
…ts with flash effect on (#6194)

# References and relevant issues

Closes #6147 

# Description

Prevent showing the layer controls buttons with a displaced layout while
using `Save Screenshot with the Viewer`:

Before:


![current_controls_flash_buttons](https://github.com/napari/napari/assets/16781833/1c629d81-4abf-4f47-bc09-387483aa30ca)

After:


![fix_controls_flash_buttons](https://github.com/napari/napari/assets/16781833/f3dfd0fb-80ae-426f-b932-fedf5aaac396)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR with bugfix qt Relates to qt UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI icons shift when saving screenshot with flash

4 participants