Skip to content

Update "toggle ndview" text#6192

Merged
Czaki merged 1 commit intonapari:mainfrom
dstansby:view-toggle-text
Sep 5, 2023
Merged

Update "toggle ndview" text#6192
Czaki merged 1 commit intonapari:mainfrom
dstansby:view-toggle-text

Conversation

@dstansby
Copy link
Copy Markdown
Contributor

@dstansby dstansby commented Aug 28, 2023

References and relevant issues

Fixes #5390

Description

Makes the tooltip shown for the switching between 2D/3D views clearer.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2023

Codecov Report

Merging #6192 (3e2883f) into main (3e0b884) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6192      +/-   ##
==========================================
+ Coverage   91.60%   91.66%   +0.05%     
==========================================
  Files         582      582              
  Lines       50965    50968       +3     
==========================================
+ Hits        46689    46720      +31     
+ Misses       4276     4248      -28     
Files Changed Coverage Δ
napari/components/_viewer_key_bindings.py 96.10% <100.00%> (ø)

... and 17 files with indirect coverage changes

@Czaki
Copy link
Copy Markdown
Collaborator

Czaki commented Aug 28, 2023

why it is draft?

@dstansby dstansby marked this pull request as ready for review August 28, 2023 13:26
@dstansby
Copy link
Copy Markdown
Contributor Author

Because I like to keep my PRs in draft until I see that the CI has passed.

@Czaki Czaki added this to the 0.4.19 milestone Aug 28, 2023
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 28, 2023
Copy link
Copy Markdown
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the docs: https://napari.org/stable/tutorials/fundamentals/viewer.html?highlight=toggle%20ndisplay#toggle-ndisplay-2d-3d-button
Or if you prefer make an issue over at the docs repo and tag me in it with a link to this PR to take care of.
Thanks!

@dstansby
Copy link
Copy Markdown
Contributor Author

Could you also update the docs: https://napari.org/stable/tutorials/fundamentals/viewer.html?highlight=toggle%20ndisplay#toggle-ndisplay-2d-3d-button Or if you prefer make an issue over at the docs repo and tag me in it with a link to this PR to take care of. Thanks!

Which bit of those docs needs updating? I'm not seeing anything obvious, but maybe I missed something 😄

@Czaki
Copy link
Copy Markdown
Collaborator

Czaki commented Aug 28, 2023

@dstansby dstansby mentioned this pull request Aug 28, 2023
6 tasks
@dstansby
Copy link
Copy Markdown
Contributor Author

dstansby commented Aug 28, 2023

Ah I must have skipped the title 😄 . I've opened a PR, linked above this comment

@Czaki Czaki merged commit deb55eb into napari:main Sep 5, 2023
@dstansby dstansby deleted the view-toggle-text branch September 5, 2023 12:31
Czaki pushed a commit to napari/docs that referenced this pull request Sep 5, 2023
# Description
Update the section title to reflect changes in the main repository. 

Depends on napari/napari#6192

## Type of change
- [x] Fixes or improves existing content
@melonora melonora removed the ready to merge Last chance for comments! Will be merged in ~24h label Sep 14, 2023
kne42 added a commit to kne42/napari that referenced this pull request Sep 19, 2023
* main: (26 commits)
  Fix some typing in napari.components (napari#6203)
  Use class name for object that does not have qt name (napari#6222)
  test: [Automatic] Constraints upgrades: `hypothesis`, `magicgui`, `psygnal`, `tensorstore`, `tifffile`, `tqdm`, `virtualenv` (napari#6143)
  Replace more np.all( ... = ...) with np.array_equal (napari#6213)
  remove np.all(... == ...) in test_surface.py (napari#6218)
  Ensure pandas Series is initialized with a list as data (napari#6226)
  Stop using temporary directory for store array for paint test (napari#6191)
  Bugfix: ensure thumbnail represents canvas when multiscale (napari#6200)
  cleanup np.all(... == ...) from test_points.py (napari#6217)
  [pre-commit.ci] pre-commit autoupdate (napari#6221)
  use app-model for file menu (napari#4865)
  Add tests to cover slicing behavior when changing layers and data (napari#4819)
  [pre-commit.ci] pre-commit autoupdate (napari#6128)
  Add test coverage for async slicing of labels (napari#5325)
  Add collision check when set colors for labels layer (napari#6193)
  Update "toggle ndview" text (napari#6192)
  Prevent layer controls buttons changing layout while taking screenshots with flash effect on (napari#6194)
  Fix typing in napari.utils.perf (napari#6132)
  Add GUI test coverage for changes to Labels.show_selected_label (napari#5372)
  Fix types in 'napari.utils.colormaps.categorical_colormap' (napari#6154)
  ...
Czaki pushed a commit that referenced this pull request Oct 17, 2023
# References and relevant issues
Fixes #5390

# Description
Makes the tooltip shown for the switching between 2D/3D views clearer.
Czaki pushed a commit that referenced this pull request Oct 25, 2023
# Description
Update the section title to reflect changes in the main repository.

Depends on #6192

## Type of change
- [x] Fixes or improves existing content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better button tooltips: "Switch 2D/3D view"

4 participants