Add collision check when set colors for labels layer#6193
Merged
Czaki merged 5 commits intonapari:mainfrom Sep 5, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6193 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.01%
==========================================
Files 582 582
Lines 51064 51095 +31
==========================================
+ Hits 46810 46844 +34
+ Misses 4254 4251 -3
|
psobolewskiPhD
approved these changes
Aug 29, 2023
brisvag
approved these changes
Aug 30, 2023
brisvag
approved these changes
Aug 30, 2023
Contributor
brisvag
left a comment
There was a problem hiding this comment.
Nice speedup changes! LGTM.
kne42
added a commit
to kne42/napari
that referenced
this pull request
Sep 19, 2023
* main: (26 commits) Fix some typing in napari.components (napari#6203) Use class name for object that does not have qt name (napari#6222) test: [Automatic] Constraints upgrades: `hypothesis`, `magicgui`, `psygnal`, `tensorstore`, `tifffile`, `tqdm`, `virtualenv` (napari#6143) Replace more np.all( ... = ...) with np.array_equal (napari#6213) remove np.all(... == ...) in test_surface.py (napari#6218) Ensure pandas Series is initialized with a list as data (napari#6226) Stop using temporary directory for store array for paint test (napari#6191) Bugfix: ensure thumbnail represents canvas when multiscale (napari#6200) cleanup np.all(... == ...) from test_points.py (napari#6217) [pre-commit.ci] pre-commit autoupdate (napari#6221) use app-model for file menu (napari#4865) Add tests to cover slicing behavior when changing layers and data (napari#4819) [pre-commit.ci] pre-commit autoupdate (napari#6128) Add test coverage for async slicing of labels (napari#5325) Add collision check when set colors for labels layer (napari#6193) Update "toggle ndview" text (napari#6192) Prevent layer controls buttons changing layout while taking screenshots with flash effect on (napari#6194) Fix typing in napari.utils.perf (napari#6132) Add GUI test coverage for changes to Labels.show_selected_label (napari#5372) Fix types in 'napari.utils.colormaps.categorical_colormap' (napari#6154) ...
Czaki
added a commit
that referenced
this pull request
Oct 17, 2023
This PR adds a check if two user-defined colors for labels above 2*23 collide in the same value after being cast to float32. We need to cast values to this type because of the texture mechanism currently used. extracted from #6182 requested in #6182 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check if two user-defined colors for labels above 2*23 collide in the same value after being cast to float32.
We need to cast values to this type because of the texture mechanism currently used.
References and relevant issues
extracted from #6182 requested in #6182 (comment)