Fix types in 'napari.utils.colormaps.categorical_colormap'#6154
Merged
andy-sweet merged 2 commits intonapari:mainfrom Aug 30, 2023
Merged
Fix types in 'napari.utils.colormaps.categorical_colormap'#6154andy-sweet merged 2 commits intonapari:mainfrom
andy-sweet merged 2 commits intonapari:mainfrom
Conversation
The only effect (beyond typing) is to validate the color at creation. ColorValue only exposes extra classmethod to work with color.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6154 +/- ##
=======================================
Coverage 91.67% 91.67%
=======================================
Files 582 582
Lines 51073 51073
=======================================
+ Hits 46819 46822 +3
+ Misses 4254 4251 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andy-sweet
reviewed
Aug 18, 2023
andy-sweet
approved these changes
Aug 18, 2023
Member
andy-sweet
left a comment
There was a problem hiding this comment.
Looks good, though the suggestion is probably worth bringing in.
andy-sweet
approved these changes
Aug 29, 2023
Member
andy-sweet
left a comment
There was a problem hiding this comment.
I merged main in and also brought in the suggestion. Will merge this after 24 hours unless I hear otherwise.
Czaki
approved these changes
Aug 29, 2023
kne42
added a commit
to kne42/napari
that referenced
this pull request
Sep 19, 2023
* main: (26 commits) Fix some typing in napari.components (napari#6203) Use class name for object that does not have qt name (napari#6222) test: [Automatic] Constraints upgrades: `hypothesis`, `magicgui`, `psygnal`, `tensorstore`, `tifffile`, `tqdm`, `virtualenv` (napari#6143) Replace more np.all( ... = ...) with np.array_equal (napari#6213) remove np.all(... == ...) in test_surface.py (napari#6218) Ensure pandas Series is initialized with a list as data (napari#6226) Stop using temporary directory for store array for paint test (napari#6191) Bugfix: ensure thumbnail represents canvas when multiscale (napari#6200) cleanup np.all(... == ...) from test_points.py (napari#6217) [pre-commit.ci] pre-commit autoupdate (napari#6221) use app-model for file menu (napari#4865) Add tests to cover slicing behavior when changing layers and data (napari#4819) [pre-commit.ci] pre-commit autoupdate (napari#6128) Add test coverage for async slicing of labels (napari#5325) Add collision check when set colors for labels layer (napari#6193) Update "toggle ndview" text (napari#6192) Prevent layer controls buttons changing layout while taking screenshots with flash effect on (napari#6194) Fix typing in napari.utils.perf (napari#6132) Add GUI test coverage for changes to Labels.show_selected_label (napari#5372) Fix types in 'napari.utils.colormaps.categorical_colormap' (napari#6154) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only effect (beyond typing) is to validate the color at creation. ColorValue only exposes extra classmethod to work with color.