Recreate moveit_resources_panda_moveit_config via MSA#92
Merged
rhaschke merged 2 commits intomoveit:masterfrom Nov 5, 2021
Merged
Recreate moveit_resources_panda_moveit_config via MSA#92rhaschke merged 2 commits intomoveit:masterfrom
rhaschke merged 2 commits intomoveit:masterfrom
Conversation
812675b to
12a1cff
Compare
JafarAbdi
reviewed
Aug 3, 2021
Contributor
|
@rhaschke As far as I know you proposed this PR as a way to solve #89, but your patch does not include the required broadcaster. Did you use an older version of MSA to generate the config? I filed #97 to solve the immediate issue for now. |
1678b85 to
44a382a
Compare
Contributor
Author
|
@v4hn, thanks for pointing out the open issues. I ran MSA once again with a recent version of MoveIt. Probably, I used the latest release before, which is already rather old... |
9ca717c to
c3c6538
Compare
c3c6538 to
f10e97d
Compare
rhaschke
added a commit
to rhaschke/moveit_resources
that referenced
this pull request
Nov 5, 2021
rhaschke
added a commit
to ubi-agni/moveit
that referenced
this pull request
May 3, 2022
Since moveit#2888 / moveit/moveit_resources#92 `planning_pipeline.launch.xml` loads into `pipeline` namespace by default, thus making an explicit specification of `ompl` redundant.
rhaschke
added a commit
to moveit/moveit
that referenced
this pull request
May 3, 2022
Since #2888 / moveit/moveit_resources#92 `planning_pipeline.launch.xml` loads into `pipeline` namespace by default, thus making an explicit specification of `ompl` redundant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as suggested by @v4hn in #89 (comment)
Thus,
moveit_resources_panda_moveit_configdiverges frompanda_moveit_config!