Skip to content

Improve launch files#2888

Merged
rhaschke merged 1 commit intomoveit:masterfrom
ubi-agni:improve-launch-files
Sep 28, 2021
Merged

Improve launch files#2888
rhaschke merged 1 commit intomoveit:masterfrom
ubi-agni:improve-launch-files

Conversation

@rhaschke
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke commented Sep 28, 2021

This PR

  • renames launch files from *.launch.xml -> .launch
  • clarifies that all planning pipelines are loaded into a namespace by doing it once in planning_pipeline.launch

@rhaschke
Load all planning pipelines into their own namespace
d8135d6 
Reduce code redundancy, specifying the namespace once in planning_pipeline.launch.
@rhaschke rhaschke requested a review from v4hn September 28, 2021 19:05
@v4hn
Copy link
Copy Markdown
Contributor

v4hn commented Sep 28, 2021

clarifies that all planning pipelines are loaded into a namespace by doing it once in planning_pipeline.launch

;+1:

renames launch files from *.launch.xml -> .launch

The old naming removes these files from roslaunch autocompletion (which only looks for the .launch suffix). With your change the completion list would be much longer for no reason. 😕

@rhaschke
Copy link
Copy Markdown
Contributor Author

rhaschke commented Sep 28, 2021

renames launch files from *.launch.xml -> .launch

The old naming removes these files from roslaunch autocompletion (which only looks for the .launch suffix). With your change the completion list would be much longer for no reason. confused

I see. I was wondering why you would like those files to be named .launch.xml. Thanks for the explanation. I will remove this commit.

@rhaschke rhaschke force-pushed the improve-launch-files branch from 3e9dfce to d8135d6 Compare September 28, 2021 20:24
@rhaschke rhaschke merged commit 049be73 into moveit:master Sep 28, 2021
@rhaschke rhaschke deleted the improve-launch-files branch September 28, 2021 20:25
rhaschke added a commit to ubi-agni/moveit that referenced this pull request May 3, 2022
@rhaschke
Fix namespace of planning plugin for benchmarks examples
a4d25d7 
Since moveit#2888 / moveit/moveit_resources#92
`planning_pipeline.launch.xml` loads into `pipeline` namespace by default,
thus making an explicit specification of `ompl` redundant.
@rhaschke rhaschke mentioned this pull request May 3, 2022
Merged
rhaschke added a commit that referenced this pull request May 3, 2022
@rhaschke
Fix namespace of planning plugin for benchmarks examples (#3128)
bb9a767 
Since #2888 / moveit/moveit_resources#92
`planning_pipeline.launch.xml` loads into `pipeline` namespace by default,
thus making an explicit specification of `ompl` redundant.
@SebiGoebel SebiGoebel mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v4hn v4hn Awaiting requested review from v4hn

@henningkayser henningkayser Awaiting requested review from henningkayser

@jschleicher jschleicher Awaiting requested review from jschleicher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhaschke @v4hn