[backport] Pilz planner merge#2507
Merged
v4hn merged 2 commits intomoveit:melodic-develfrom Mar 2, 2021
Merged
Conversation
* Add pilz_industrial_motion_planner to moveit_planners * Update license, document consent to this change by contributers * Fix formatting, code style, catkin_lint, clang-tidy * Add and update tests, use new prvt_moveit_config from moveit_resources * New codeowners for pilz_industrial_motion planner * Add pipeline configuration teimplates to MSA Co-authored-by: Joachim Schleicher <J.Schleicher@pilz.de> Co-authored-by: rfeistenauer <r.feistenauer@pilz.de> Co-authored-by: Giuseppe Sansone <g.sansone@pilz.de> Co-authored-by: Immanuel Martini <i.martini@pilz.de>
Codecov Report
@@ Coverage Diff @@
## melodic-devel #2507 +/- ##
=================================================
+ Coverage 51.28% 55.74% +4.47%
=================================================
Files 323 401 +78
Lines 23307 25343 +2036
=================================================
+ Hits 11951 14126 +2175
+ Misses 11356 11217 -139
Continue to review full report at Codecov.
|
This was referenced Feb 3, 2021
jschleicher
approved these changes
Feb 4, 2021
Contributor
jschleicher
left a comment
There was a problem hiding this comment.
This cherry-pick brings the pilz_industrial_motion_planner to melodic.
Contributor
|
I'm puzzled about this not being merged after weeks. This was previously reviewed, passes CI and only adds functionality without touching anything else. |
15 tasks
Comment on lines
+50
to
+51
| <param name="capabilities" value="$(arg capabilities)"/> | ||
| <param name="disable_capabilities" value="$(arg disable_capabilities)"/> |
Member
There was a problem hiding this comment.
I've just ran into a problem with roslaunch complaining that param is unexpected here in an include. And it's correct.
Should this be arg instead? Seems this is a problem on Melodic, which doesn't have #2127, which corrected this.
Member
gavanderhoorn
added a commit
that referenced
this pull request
Jun 22, 2021
These two lines were moved here (from the `move_group` node section below) in #2507 as part of the Melodic backport of the Pilz planner, but were not changed to `arg`s. `include` elements do not support `param` children. Change these to `arg`s to make `roslaunch` pass them on to `planning_pipeline.launch.xml` as intended. Note: this is not a problem on `master` (and consequently `noetic-devel`), as #2127 rearranged things again (to move capabilities management to the per-pipeline launch files) and fixed it.
v4hn
pushed a commit
that referenced
this pull request
Jun 22, 2021
These two lines were moved here (from the `move_group` node section below) in #2507 as part of the Melodic backport of the Pilz planner, but were not changed to `arg`s. `include` elements do not support `param` children. Change these to `arg`s to make `roslaunch` pass them on to `planning_pipeline.launch.xml` as intended. Note: this is not a problem on `master` (and consequently `noetic-devel`), as #2127 rearranged things again (to move capabilities management to the per-pipeline launch files) and fixed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Melodic backport adding the pilz_industrial_motion_planner (#1893)
Tutorial: moveit/moveit_tutorials#583
Checklist
Document API changes relevant to the user in the MIGRATION.md notesCreate tests, which fail without this PR referenceInclude a screenshot if changing a GUI