msa: capabilities-related args are args in template (fix #2728)#2729
Merged
v4hn merged 1 commit intomelodic-develfrom Jun 22, 2021
Merged
msa: capabilities-related args are args in template (fix #2728)#2729v4hn merged 1 commit intomelodic-develfrom
v4hn merged 1 commit intomelodic-develfrom
Conversation
These two lines were moved here (from the `move_group` node section below) in #2507 as part of the Melodic backport of the Pilz planner, but were not changed to `arg`s. `include` elements do not support `param` children. Change these to `arg`s to make `roslaunch` pass them on to `planning_pipeline.launch.xml` as intended. Note: this is not a problem on `master` (and consequently `noetic-devel`), as #2127 rearranged things again (to move capabilities management to the per-pipeline launch files) and fixed it.
Member
Author
|
Apologies. I assumed GH was creating a branch on my personal fork :( |
Codecov Report
@@ Coverage Diff @@
## melodic-devel #2729 +/- ##
=================================================
+ Coverage 55.33% 55.35% +0.02%
=================================================
Files 393 393
Lines 28183 28183
=================================================
+ Hits 15593 15598 +5
+ Misses 12590 12585 -5
Continue to review full report at Codecov.
|
v4hn
approved these changes
Jun 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per subject.
See #2728 for discussion, and the commit comment for the rationale.