Skip to content

weighted scheduling methods constants for ipvs#2453

Merged
selansen merged 3 commits intomoby:masterfrom
jdrahos:ipvs_weighted_scheduling_constants-2452
Sep 28, 2019
Merged

weighted scheduling methods constants for ipvs#2453
selansen merged 3 commits intomoby:masterfrom
jdrahos:ipvs_weighted_scheduling_constants-2452

Conversation

@jdrahos
Copy link
Contributor

@jdrahos jdrahos commented Sep 24, 2019

Small change related to #2452
Two new scheduling method constants were added for ipvs

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "ipvs_weighted_scheduling_constants-2452" git@github.com:jdrahos/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@arkodg
Copy link
Contributor

arkodg commented Sep 24, 2019

@jdrahos thanks for raising this PR, can you please add the corresponding constants in ipvs/ipvs_test.go

@jdrahos jdrahos force-pushed the ipvs_weighted_scheduling_constants-2452 branch from 5942aa5 to c5e7162 Compare September 25, 2019 00:58
Signed-off-by: Jakub Drahos <jack.drahos@gmail.com>
@jdrahos jdrahos force-pushed the ipvs_weighted_scheduling_constants-2452 branch from c5e7162 to c3c0fab Compare September 25, 2019 01:02
Signed-off-by: Jakub Drahos <jack.drahos@gmail.com>
@jdrahos
Copy link
Contributor Author

jdrahos commented Sep 25, 2019

@arkodg added the constants to the test as requested. The CI has failed but it looks like it is not related to the change. Running the tests locally is passing so assume this is being a flaky test or something.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdrahos can you please push your commit again to rerun the CI
cc @euanh @selansen

Signed-off-by: Jakub Drahos <jack.drahos@gmail.com>
@jdrahos
Copy link
Contributor Author

jdrahos commented Sep 25, 2019

Thank you @arkodg for your help, the CI passed after re-run.

@arkodg
Copy link
Contributor

arkodg commented Sep 25, 2019

cc @selansen

@selansen selansen merged commit 27a47ab into moby:master Sep 28, 2019
espensuenson added a commit to espensuenson/moby that referenced this pull request Oct 1, 2019
Issues that are fixed :
log the actual error when failing to add IPv6 route moby/libnetwork#2444
Shorten controller ID in exec-root to not hit UNIX_PATH_MAX moby/libnetwork#2443
Fixed getNetworkFromStore, which returned an incorrect struct moby/libnetwork#2449
weighted scheduling methods constants for ipvs moby/libnetwork#2453
Resolve "bridge fdb show" hang issue moby/libnetwork#2456

Signed-off-by: Espen Suenson <mail@espensuenson.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants