Fixed getNetworkFromStore, which returned an incorrect struct#2449
Merged
selansen merged 2 commits intomoby:masterfrom Sep 28, 2019
Merged
Fixed getNetworkFromStore, which returned an incorrect struct#2449selansen merged 2 commits intomoby:masterfrom
selansen merged 2 commits intomoby:masterfrom
Conversation
…on - notably, the 'resolver' field was empty. This fixes moby/moby#38901 Signed-off-by: Espen Suenson <mail@espensuenson.dk>
Contributor
Author
|
@thaJeztah any chance that this PR will be looked at soon? We cannot use docker networks for continuous integration until the associated bug is fixed. |
Member
vikramhh
reviewed
Sep 23, 2019
vikramhh
left a comment
There was a problem hiding this comment.
Possibly we should return immediately after line 83 in case of error. Otherwise an empty map iteration would lead to "network not found" error being returned instead of the actual error from getNetworksFromStore.
|
Please sign your commits following these rules: $ git clone -b "bugfix_getnetworkfromstore" git@github.com:espensuenson/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354325096
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Espen Suenson <mail@espensuenson.dk>
8877bee to
a35a770
Compare
Contributor
Author
|
@vikramhh I changed it to return immediately in case of error. |
|
@espensuenson - thanks. LGTM |
espensuenson
added a commit
to espensuenson/moby
that referenced
this pull request
Oct 1, 2019
Issues that are fixed : log the actual error when failing to add IPv6 route moby/libnetwork#2444 Shorten controller ID in exec-root to not hit UNIX_PATH_MAX moby/libnetwork#2443 Fixed getNetworkFromStore, which returned an incorrect struct moby/libnetwork#2449 weighted scheduling methods constants for ipvs moby/libnetwork#2453 Resolve "bridge fdb show" hang issue moby/libnetwork#2456 Signed-off-by: Espen Suenson <mail@espensuenson.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed getNetworkFromStore, which returned incorrect network information - notably, the 'resolver' field was empty.
This fixes moby/moby#38901
Signed-off-by: Espen Suenson mail@espensuenson.dk