log the actual error when failing to add IPv6 route#2444
Merged
selansen merged 1 commit intomoby:masterfrom Sep 28, 2019
Merged
log the actual error when failing to add IPv6 route#2444selansen merged 1 commit intomoby:masterfrom
selansen merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Kamil Domański <kamil@domanski.co>
arkodg
approved these changes
Sep 24, 2019
Contributor
arkodg
left a comment
There was a problem hiding this comment.
LGTM thanks @kdomanski
PTAL @euanh
espensuenson
added a commit
to espensuenson/moby
that referenced
this pull request
Oct 1, 2019
Issues that are fixed : log the actual error when failing to add IPv6 route moby/libnetwork#2444 Shorten controller ID in exec-root to not hit UNIX_PATH_MAX moby/libnetwork#2443 Fixed getNetworkFromStore, which returned an incorrect struct moby/libnetwork#2449 weighted scheduling methods constants for ipvs moby/libnetwork#2453 Resolve "bridge fdb show" hang issue moby/libnetwork#2456 Signed-off-by: Espen Suenson <mail@espensuenson.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kamil Domański kamil@domanski.co
Currently the error message
Could not add route to IPv6 network %s via device %sobscures the cause of the issue by not logging the original error as well.