Shorten controller ID in exec-root to not hit UNIX_PATH_MAX#2443
Merged
selansen merged 2 commits intomoby:masterfrom Sep 28, 2019
Merged
Shorten controller ID in exec-root to not hit UNIX_PATH_MAX#2443selansen merged 2 commits intomoby:masterfrom
selansen merged 2 commits intomoby:masterfrom
Conversation
Signed-off-by: Grant Millar <rid@cylo.io>
Contributor
Author
|
@fcrisciani @ctelfer @AkihiroSuda PTAL? |
AkihiroSuda
approved these changes
Sep 11, 2019
Contributor
|
@Rid can you please retry, the failed test is |
|
Please sign your commits following these rules: $ git clone -b "shorten-setkey-id" git@github.com:Rid/libnetwork.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354554968
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
a5e1f06 to
bdeccb5
Compare
Contributor
Author
|
@arkodg done, it's now passed. |
Contributor
Contributor
|
Thanks @Rid |
espensuenson
added a commit
to espensuenson/moby
that referenced
this pull request
Oct 1, 2019
Issues that are fixed : log the actual error when failing to add IPv6 route moby/libnetwork#2444 Shorten controller ID in exec-root to not hit UNIX_PATH_MAX moby/libnetwork#2443 Fixed getNetworkFromStore, which returned an incorrect struct moby/libnetwork#2449 weighted scheduling methods constants for ipvs moby/libnetwork#2453 Resolve "bridge fdb show" hang issue moby/libnetwork#2456 Signed-off-by: Espen Suenson <mail@espensuenson.dk>
This was referenced Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Millar rid@cylo.io
Use short controller ID in setkey in order to avoid moby/moby#39608 where using a custom exec-root which contains > 27 chars before the controller ID causes the daemon to fail starting with:
This happens due to hitting the UNIX_PATH_MAX limit (which is 108, ours is 115 in the example above). The patch gives us 79 chars to play with vs 27.