Merged
Conversation
This removes duplicated information when instantiating variables, and increases the readability. For example:
```Java
EnumMap<CallableHandles, HandleAssociation> handleMap =
new EnumMap<CallableHandles, HandleAssociation>(CallableHandles.class);
```
becomes
```Java
EnumMap<CallableHandles, HandleAssociation> handleMap =
new EnumMap<>(CallableHandles.class);
```
and
```Java
private static final EnumMap<SSType.Category, EnumSet<JDBCType.Category>> conversionMap =
new EnumMap<SSType.Category, EnumSet<JDBCType.Category>>(SSType.Category.class);
```
becomes
```Java
private static final EnumMap<SSType.Category, EnumSet<JDBCType.Category>> conversionMap =
new EnumMap<>(SSType.Category.class);
```
This increases the overall readability of the code, and has been supported since Java 5.
Replace tabs with spaces
Fixed issue with returning class type of time object in sql_variant
update error messages for localization
Fix typo in Javadoc
…l_variant_temproal_fix # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
…l_variant_temproal_fix
sql_variant issue with String type
Fixed issue with throwing error message for unsupported datatype.
…de-impact-setNull Make send string parameter as unicode impact set/update null
* Fixing a few mistakes in SQLServerResource * Fix the test
Skip long running tests
* Removing fipsProvider connection property * Minor fix * Update IOBuffer.java Fix typo * update FipsTest
Replace for and while loops with foeach loops
This reverts commit e277087.
…/mssql-jdbc into JamieMagee-explicit-type-diamond
Replace explicit types with <> (The diamond operator).
Throw the initial batchException
prepare for 6.3.2
AfsanehR-zz
approved these changes
Sep 6, 2017
Codecov Report
@@ Coverage Diff @@
## master #479 +/- ##
============================================
- Coverage 46.37% 46.31% -0.07%
- Complexity 2204 2207 +3
============================================
Files 108 108
Lines 25212 25231 +19
Branches 4165 4173 +8
============================================
- Hits 11693 11686 -7
- Misses 11492 11526 +34
+ Partials 2027 2019 -8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.