Replace for and while loops with foeach loops#421
Merged
peterbae merged 1 commit intomicrosoft:devfrom Aug 31, 2017
Merged
Conversation
This increases the overall readability of the code, and has been supported since Java 5.
Codecov Report
@@ Coverage Diff @@
## dev #421 +/- ##
===========================================
+ Coverage 45.92% 46% +0.08%
- Complexity 2198 2203 +5
===========================================
Files 108 108
Lines 25210 25193 -17
Branches 4164 4164
===========================================
+ Hits 11577 11591 +14
+ Misses 11711 11677 -34
- Partials 1922 1925 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #421 +/- ##
===========================================
+ Coverage 45.92% 46% +0.08%
- Complexity 2198 2203 +5
===========================================
Files 108 108
Lines 25210 25193 -17
Branches 4164 4164
===========================================
+ Hits 11577 11591 +14
+ Misses 11711 11677 -34
- Partials 1922 1925 +3
Continue to review full report at Codecov.
|
cheenamalhotra
approved these changes
Aug 24, 2017
Member
cheenamalhotra
left a comment
There was a problem hiding this comment.
ForEach loops are ideally more efficient way of performing iterations. I don't see any issues with these changes. We shall merge this PR soon.
Member
Author
|
@cheenamalhotra Thanks for the review. Is it possible to merge this now? |
Member
|
Hi @JamieMagee, we'll merge your two PRs with the next preview release (v6.3.2). |
Contributor
|
Testing was good, merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the overall readability of the code, and has been supported since Java 5.