Skip to content

sql_variant issue with String type#442

Merged
AfsanehR-zz merged 5 commits intomicrosoft:devfrom
AfsanehR-zz:sql_variant_fix
Aug 29, 2017
Merged

sql_variant issue with String type#442
AfsanehR-zz merged 5 commits intomicrosoft:devfrom
AfsanehR-zz:sql_variant_fix

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Aug 14, 2017

fixes issue #439

@AfsanehR-zz AfsanehR-zz mentioned this pull request Aug 14, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 14, 2017 •
edited
Loading

Codecov Report

Merging #442 into dev will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #442      +/-   ##
============================================
- Coverage     46.37%   46.31%   -0.07%     
+ Complexity     2200     2198       -2     
============================================
  Files           108      108              
  Lines         25212    25260      +48     
  Branches       4165     4177      +12     
============================================
+ Hits          11692    11699       +7     
- Misses        11493    11540      +47     
+ Partials       2027     2021       -6
Flag Coverage Δ Complexity Δ
#JDBC41 46.04% <100%> (-0.07%) 2184 <0> (-2)
#JDBC42 46.19% <100%> (-0.01%) 2195 <0> (+3)
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.81% <100%> (-0.68%) 0 <0> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.6% <0%> (-1.63%) 28% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.04% <0%> (-0.68%) 103% <0%> (-2%)
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 46.61% <0%> (-0.52%) 66% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.35% <0%> (-0.2%) 238% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.08% <0%> (-0.17%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.98% <0%> (-0.17%) 242% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 50.82% <0%> (-0.09%) 161% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ab207...e207571. Read the comment docs.

@AfsanehR-zz AfsanehR-zz added this to the 6.3.2 milestone Aug 21, 2017
@AfsanehR-zz AfsanehR-zz merged commit 80a4665 into microsoft:dev Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@peterbae peterbae

Labels

None yet

Projects

None yet

Milestone

6.3.2

Development

Successfully merging this pull request may close these issues.

5 participants

@AfsanehR-zz @codecov-io @peterbae @lilgreenbird @msftclas