Skip to content

Throw the initial batchException #458

Merged
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
AfsanehR-zz:batchUpdateException
Sep 1, 2017
Merged

Throw the initial batchException #458
AfsanehR-zz merged 2 commits intomicrosoft:devfrom
AfsanehR-zz:batchUpdateException

Conversation

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

@AfsanehR-zz AfsanehR-zz commented Aug 23, 2017

Fixes #457 . In case of batch updates, driver hides the custom trigger error messages.

@AfsanehR-zz AfsanehR-zz mentioned this pull request Aug 23, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 23, 2017 •
edited
Loading

Codecov Report

Merging #458 into dev will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #458      +/-   ##
============================================
+ Coverage     46.33%   46.35%   +0.02%     
+ Complexity     2202     2201       -1     
============================================
  Files           108      108              
  Lines         25248    25268      +20     
  Branches       4170     4177       +7     
============================================
+ Hits          11698    11714      +16     
+ Misses        11531    11529       -2     
- Partials       2019     2025       +6
Flag Coverage Δ Complexity Δ
#JDBC41 46.12% <50%> (-0.05%) 2187 <0> (-7)
#JDBC42 46.26% <50%> (+0.16%) 2200 <0> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 51.57% <50%> (+0.9%) 165 <0> (+4) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 51.11% <0%> (-1.49%) 11% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.26% <0%> (-0.45%) 104% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.49% <0%> (-0.37%) 239% <0%> (-3%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.84% <0%> (-0.08%) 274% <0%> (-2%)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 29.7% <0%> (ø) 49% <0%> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.36% <0%> (ø) 130% <0%> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerCallableStatement.java 29.19% <0%> (+0.03%) 90% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93e087c...1892ee1. Read the comment docs.

@AfsanehR-zz AfsanehR-zz added this to the 6.3.2 milestone Aug 28, 2017
@AfsanehR-zz AfsanehR-zz merged commit b7fee51 into microsoft:dev Sep 1, 2017
@fhossfel fhossfel mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NicolaIsotta NicolaIsotta NicolaIsotta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.2

Development

Successfully merging this pull request may close these issues.

5 participants

@AfsanehR-zz @codecov-io @NicolaIsotta @lilgreenbird @msftclas