Skip to content

Make send string parameter as unicode impact set/update null#445

Merged
AfsanehR-zz merged 4 commits intomicrosoft:devfrom
xiangyushawn:make-sendStringParameterAsUnicode-impact-setNull
Aug 31, 2017
Merged

Make send string parameter as unicode impact set/update null#445
AfsanehR-zz merged 4 commits intomicrosoft:devfrom
xiangyushawn:make-sendStringParameterAsUnicode-impact-setNull

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Aug 15, 2017

fix issue #437

@xiangyushawn xiangyushawn changed the title Make send string parameter as unicode impact set null Make send string parameter as unicode impact set/update null Aug 15, 2017
@xiangyushawn xiangyushawn mentioned this pull request Aug 15, 2017
Closed
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 15, 2017 •
edited
Loading

Codecov Report

Merging #445 into dev will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #445      +/-   ##
============================================
- Coverage     46.37%   46.22%   -0.16%     
  Complexity     2200     2200              
============================================
  Files           108      108              
  Lines         25212    25212              
  Branches       4165     4165              
============================================
- Hits          11692    11654      -38     
- Misses        11493    11541      +48     
+ Partials       2027     2017      -10
Flag Coverage Δ Complexity Δ
#JDBC41 46.04% <0%> (-0.08%) 2185 <0> (-1)
#JDBC42 46.07% <0%> (-0.12%) 2197 <0> (+5)
Impacted Files Coverage Δ Complexity Δ
...main/java/com/microsoft/sqlserver/jdbc/Column.java 34.54% <ø> (ø) 34 <0> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.23% <0%> (-1.51%) 63 <0> (+1)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 42.47% <0%> (-2.25%) 102% <0%> (-3%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.6% <0%> (-1.63%) 28% <0%> (-1%)
...va/com/microsoft/sqlserver/jdbc/StreamColumns.java 87.83% <0%> (-1.36%) 21% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.17% <0%> (-0.65%) 88% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.01% <0%> (-0.49%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.98% <0%> (-0.27%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.06% <0%> (-0.09%) 245% <0%> (+2%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97ab207...cc11277. Read the comment docs.

@AfsanehR-zz AfsanehR-zz added this to the 6.3.2 milestone Aug 21, 2017
peterbae
peterbae approved these changes Aug 25, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@peterbae peterbae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@AfsanehR-zz AfsanehR-zz merged commit 3c9f635 into microsoft:dev Aug 31, 2017
@xiangyushawn xiangyushawn deleted the make-sendStringParameterAsUnicode-impact-setNull branch September 8, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheenamalhotra cheenamalhotra cheenamalhotra approved these changes

+1 more reviewer

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.3.2

Development

Successfully merging this pull request may close these issues.

7 participants

@xiangyushawn @codecov-io @cheenamalhotra @peterbae @lilgreenbird @msftclas @AfsanehR-zz