Conversation
… will be only for getters and adding the test
…lVariant # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/PLPInputStream.java resolved conflicts
Sql_Variant initial development
Sql variant
Java offers two kinds of multi line comments /** and /*. The first is called Javadoc and ends up in generated API documentation and is displayed by IDEs. The second is a multi line comment that does not show up. There are several places there /* instead of /** is used for API documentation. [1] https://stackoverflow.com/questions/29815636/and-in-java-comments [2] http://javadude.com/articles/comments.html
The optional ResultSet#getObject(int, Class) and ResultSet#getObject(String, Class) methods are currently not implemented. Besides the conversions mentioned in appendix Appendix B, Table B-3 we also support uniqueidentifier <-> UUID. This commit does not include support for JSR-310 data types in order to keep it smaller. Fixes #6
Usage of the Java Enum feature can be improved by the driver. This commit includes the following changes: - use ordinal where possible - make enum fields final where possible
All tests are passing, merging for next major release. @brettwooldridge, now you can start a PR against dev :-)
Revert "Metadata caching - Parsed SQL and prepared statement handle caching"
Use Javadoc for API documentation
Improve enum usage
UTC is an enum with one constant and a static variable. It has the
following comment
> The enum type delays initialization until first use.
This is demonstrably wrong.
The static variable is initialized when the class is initialized. If we
look at the decompiled static initializer of UTC we see that.
```
// access flags 0x8
static <clinit>()V
L0
LINENUMBER 522 L0
NEW com/microsoft/sqlserver/jdbc/UTC
DUP
LDC "INSTANCE"
ICONST_0
INVOKESPECIAL com/microsoft/sqlserver/jdbc/UTC.<init> (Ljava/lang/String;I)V
PUTSTATIC com/microsoft/sqlserver/jdbc/UTC.INSTANCE : Lcom/microsoft/sqlserver/jdbc/UTC;
ICONST_1
ANEWARRAY com/microsoft/sqlserver/jdbc/UTC
DUP
ICONST_0
GETSTATIC com/microsoft/sqlserver/jdbc/UTC.INSTANCE : Lcom/microsoft/sqlserver/jdbc/UTC;
AASTORE
PUTSTATIC com/microsoft/sqlserver/jdbc/UTC.ENUM$VALUES : [Lcom/microsoft/sqlserver/jdbc/UTC;
L1
LINENUMBER 524 L1
NEW java/util/SimpleTimeZone
DUP
ICONST_0
LDC "UTC"
INVOKESPECIAL java/util/SimpleTimeZone.<init> (ILjava/lang/String;)V
PUTSTATIC com/microsoft/sqlserver/jdbc/UTC.timeZone : Ljava/util/TimeZone;
RETURN
MAXSTACK = 4
MAXLOCALS = 0
```
…into SqlVariant # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataTest.java # src/test/java/com/microsoft/sqlserver/testframework/Utils.java
Junit testing
Remove explicit boxing and unboxing
…ame contains braces
Fix parameter metadata
…lVariant # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
sql_variant support
Meta data caching batch query issue
Fix tvp issue with null value
6.3.0 release doc changes
|
@peterbae, |
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
============================================
+ Coverage 40.08% 46.17% +6.09%
- Complexity 1887 2205 +318
============================================
Files 107 108 +1
Lines 24482 25210 +728
Branches 4038 4164 +126
============================================
+ Hits 9813 11641 +1828
+ Misses 12832 11648 -1184
- Partials 1837 1921 +84
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.