Skip to content

Improve enum usage#307

Merged
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
marschall:enum-usage
Jun 13, 2017
Merged

Improve enum usage#307
AfsanehR-zz merged 1 commit intomicrosoft:devfrom
marschall:enum-usage

Conversation

@marschall
Copy link
Copy Markdown
Contributor

@marschall marschall commented May 20, 2017

Usage of the Java Enum feature can be improved by the driver. This
commit includes the following changes:

  • use ordinal where possible
  • make enum fields final where possible

@marschall
Improve enum usage
8661a00 
Usage of the Java Enum feature can be improved by the driver. This
commit includes the following changes:

 - use ordinal where possible
 - make enum fields final where possible
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 20, 2017 •
edited
Loading

Codecov Report

Merging #307 into dev will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #307      +/-   ##
============================================
+ Coverage     37.23%   37.25%   +0.02%     
- Complexity     1663     1669       +6     
============================================
  Files           103      103              
  Lines         23673    23667       -6     
  Branches       3882     3880       -2     
============================================
+ Hits           8814     8818       +4     
+ Misses        13261    13259       -2     
+ Partials       1598     1590       -8
Flag Coverage Δ Complexity Δ
#JDBC41 37.11% <50%> (+0.03%) 1660 <0> (+3) ⬆️
#JDBC42 37.08% <50%> (-0.01%) 1663 <0> (+7)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/SQLServerSortOrder.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...rosoft/sqlserver/jdbc/SQLServerEncryptionType.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/com/microsoft/sqlserver/jdbc/AE.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 73.79% <100%> (ø) 25 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.79% <0%> (-1.48%) 9% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 45.62% <0%> (-0.24%) 61% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 30.13% <0%> (-0.23%) 57% <0%> (+1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 46.11% <0%> (-0.18%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.11% <0%> (+0.07%) 212% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.15% <0%> (+0.12%) 186% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b87c3...8661a00. Read the comment docs.

@AfsanehR-zz AfsanehR-zz self-requested a review June 12, 2017 23:12
@AfsanehR-zz AfsanehR-zz merged commit 43dda17 into microsoft:dev Jun 13, 2017
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Jun 13, 2017

Thank you for you contribution @marschall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AfsanehR-zz AfsanehR-zz AfsanehR-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marschall @codecov-io @AfsanehR-zz @lilgreenbird @msftclas @ajlam @v-nisidh