Meta data caching batch query issue#393
Merged
AfsanehR-zz merged 6 commits intomicrosoft:devfrom Jul 27, 2017
Merged
Conversation
Contributor
Author
|
Using the test repro raised by @thomek, this is what the profiler shows before this pr: Result of profiler after the changes made: The issue is when we hit the error message of "could not find prepared statement with handle x", we don't reset the batch parameters and reset the preparedTypeDefinitions @TobiasSQL your thoughts are appreciated on this. |
Codecov Report
@@ Coverage Diff @@
## dev #393 +/- ##
===========================================
+ Coverage 40.12% 44.92% +4.8%
- Complexity 1890 2132 +242
===========================================
Files 107 107
Lines 24482 24671 +189
Branches 4038 4102 +64
===========================================
+ Hits 9823 11084 +1261
+ Misses 12820 11723 -1097
- Partials 1839 1864 +25
Continue to review full report at Codecov.
|
Contributor
Author
TobiasSQL
approved these changes
Jul 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #375 and issue #374