Skip to content

Batch support is broken, when setNull is used#374

Closed
rPraml wants to merge 2 commits intomicrosoft:masterfrom
FOCONIS:bug/batch-is-broken-when-setnull-is-used
Closed

Batch support is broken, when setNull is used#374
rPraml wants to merge 2 commits intomicrosoft:masterfrom
FOCONIS:bug/batch-is-broken-when-setnull-is-used

Conversation

@rPraml
Copy link
Copy Markdown
Contributor

@rPraml rPraml commented Jul 7, 2017

Use case
In our application we got sporadically a PRIMARY KEY violation, which we could not explain. After investigating we found out, that this happens since we updated to 6.2.0 (6.1.7.jre8-preview works)

Steps to reproduce
do several pstmt.setNull & pstmt.setString commands ln a certain order

How to fix

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 7, 2017

@rPraml,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@rPraml rPraml mentioned this pull request Jul 7, 2017
Merged
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 7, 2017 •
edited
Loading

Codecov Report

Merging #374 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #374      +/-   ##
============================================
- Coverage     40.16%   40.04%   -0.12%     
+ Complexity     1892     1882      -10     
============================================
  Files           107      107              
  Lines         24482    24482              
  Branches       4038     4038              
============================================
- Hits           9833     9805      -28     
- Misses        12815    12847      +32     
+ Partials       1834     1830       -4
Flag Coverage Δ Complexity Δ
#JDBC41 39.88% <ø> (-0.17%) 1874 <ø> (-9)
#JDBC42 39.99% <ø> (-0.03%) 1880 <ø> (-5)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-3.38%) 16% <0%> (-1%)
src/main/java/microsoft/sql/DateTimeOffset.java 37.14% <0%> (-2.86%) 8% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.4% <0%> (-1.49%) 9% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 35.71% <0%> (-0.87%) 46% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 26.86% <0%> (-0.55%) 184% <0%> (-4%)
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.06% <0%> (-0.31%) 129% <0%> (-1%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 42.14% <0%> (-0.26%) 136% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 39.45% <0%> (-0.21%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.43% <0%> (-0.08%) 210% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd68b5...e46ddbd. Read the comment docs.

@msftclas
Copy link
Copy Markdown

msftclas commented Jul 7, 2017

@rPraml, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Jul 7, 2017

@rPraml Thank you for providing the test. We are investigating this.

@AfsanehR-zz AfsanehR-zz mentioned this pull request Jul 18, 2017
Merged
@AfsanehR-zz
Copy link
Copy Markdown
Contributor

AfsanehR-zz commented Jul 27, 2017

Closing this pr as got merged with pr #393. Thank you @rPraml for providing the valuable repro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rPraml @msftclas @codecov-io @AfsanehR-zz @lilgreenbird