@JamieMagee - thanks for the suggestion. We need to add a few more test cases for casting. We'll revisit this PR once they've been added.

Hello @JamieMagee , could you please restore your branch if possible? so we can reopen this PR. It was deleted unintendedly.

@v-xiangs Sure, I've restored it now.

@JamieMagee Thank you very much for the quick response.

I've updated the branch to resolve any merge conflicts.

Codecov Report

Merging #84 into dev will increase coverage by 1.28%.
The diff coverage is 24.42%.

@@             Coverage Diff              @@
##                dev      #84      +/-   ##
============================================
+ Coverage     40.16%   41.44%   +1.28%     
- Complexity     1892     1983      +91     
============================================
  Files           107      107              
  Lines         24482    24669     +187     
  Branches       4038     4102      +64     
============================================
+ Hits           9833    10224     +391     
+ Misses        12815    12554     -261     
- Partials       1834     1891      +57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bd68b5...d09ab27. Read the comment docs.

@JamieMagee Thank you for your hard works !

Hi @JamieMagee, thanks for the contribution! A couple of suggestions:

1. In FailOverInfo.java, I think we could use Integer.parseInt instead of instantiating another Integer object (and then unboxing it into int again since portNumber is int).
2. For SqlTypeValue.java, could we try replacing all the tabs (since they're inconsistent across different machines) from lines 19 through 38 with spaces instead, and pad the spaces in between parameters (with spaces) so that the layout of the variables stay the same as before (as in, the 3 parameters for each data type would match the spacing of the minValue, maxValue and nullValue comments on line 19, respectively)? The removal of explicit autoboxing part is good. If the tabs look different on your machine and you're not sure about the original spacing, I can edit the file for you as well.

Other than those 2, the changes look good.

@peterbae Thanks for the feedback. I've been a little busy, most recently with oneweek, but I'll make the changes as soon as I have some time.

@JamieMagee Thanks for the reply. We wanted to include this in our next release so I've made the small formatting changes to one file. I will merge this PR after the tests have passed.

Test results are good. Merging in.

@peterbae Thanks for all your help with getting this PR merged 👍