Skip to content

Fix parameter metadata#410

Merged
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:fix-parameter-metadata
Jul 26, 2017
Merged

Fix parameter metadata#410
xiangyushawn merged 3 commits intomicrosoft:devfrom
xiangyushawn:fix-parameter-metadata

Conversation

@xiangyushawn
Copy link
Copy Markdown
Contributor

@xiangyushawn xiangyushawn commented Jul 26, 2017

fix an error on parameter metadata with SQL Server 2008 when calling insertion and parameter name contains braces

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 26, 2017 •
edited
Loading

Codecov Report

Merging #410 into dev will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #410      +/-   ##
============================================
- Coverage     45.01%   44.94%   -0.07%     
+ Complexity     2135     2132       -3     
============================================
  Files           107      107              
  Lines         24669    24670       +1     
  Branches       4102     4102              
============================================
- Hits          11104    11089      -15     
- Misses        11705    11724      +19     
+ Partials       1860     1857       -3
Flag Coverage Δ Complexity Δ
#JDBC41 44.69% <0%> (-0.05%) 2118 <0> (+3)
#JDBC42 44.82% <0%> (-0.03%) 2129 <0> (-4)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 23.98% <0%> (+0.16%) 31 <0> (+1) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 31.72% <0%> (-0.9%) 242% <0%> (-7%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 58.44% <0%> (-0.22%) 56% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.71% <0%> (-0.15%) 213% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 59.65% <0%> (-0.14%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 54.68% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.87% <0%> (+0.3%) 139% <0%> (+1%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.04% <0%> (+0.43%) 91% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e20ed...78d40e0. Read the comment docs.

@peterbae peterbae self-assigned this Jul 26, 2017
@xiangyushawn xiangyushawn merged commit a8ef027 into microsoft:dev Jul 26, 2017
@xiangyushawn xiangyushawn deleted the fix-parameter-metadata branch July 26, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@peterbae peterbae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xiangyushawn @codecov-io @peterbae @lilgreenbird @msftclas @ajlam