Skip to content

feat: add accessibility docs to Link about color/underlines#31121

Merged
smhigley merged 2 commits intomicrosoft:masterfrom
smhigley:link-color-docs
Apr 19, 2024
Merged

feat: add accessibility docs to Link about color/underlines#31121
smhigley merged 2 commits intomicrosoft:masterfrom
smhigley:link-color-docs

Conversation

@smhigley
Copy link
Contributor

@smhigley smhigley commented Apr 19, 2024

Docs-only PR, no package changes.

Previous Behavior

We provided an underline variant, but not guidance on why it might be needed. This PR makes 3 changes:

  1. adds docs wording in an a11y section
  2. adds an underline to the inline span story, since it would otherwise fail the WCAG criterion & not meet our guidance 😅
  3. adds underline styles to storybook links, since it seems a little too on the nose to have a failing link style in the paragraph about not making failing link styles

New Behavior

has guidance!

@smhigley smhigley requested review from a team and khmakoto as code owners April 19, 2024 16:50
@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 19, 2024
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 19, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 36 37 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 631 638 5000
Button mount 295 302 5000
Field mount 1104 1119 5000
FluentProvider mount 704 711 5000
FluentProviderWithTheme mount 81 87 10
FluentProviderWithTheme virtual-rerender 36 37 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 73 72 10
MakeStyles mount 897 870 50000
Persona mount 1738 1706 5000
SpinButton mount 1359 1370 5000
SwatchPicker mount 1551 1549 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 88 86 1.02:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 91 82 1.11:1
ChatDuplicateMessagesPerf.default 163 154 1.06:1
RefMinimalPerf.default 114 108 1.06:1
AttachmentSlotsPerf.default 675 642 1.05:1
AvatarMinimalPerf.default 111 106 1.05:1
DropdownManyItemsPerf.default 395 375 1.05:1
GridMinimalPerf.default 195 186 1.05:1
CardMinimalPerf.default 315 302 1.04:1
ItemLayoutMinimalPerf.default 732 701 1.04:1
SegmentMinimalPerf.default 197 190 1.04:1
CheckboxMinimalPerf.default 1153 1117 1.03:1
EmbedMinimalPerf.default 1889 1838 1.03:1
InputMinimalPerf.default 552 535 1.03:1
ProviderMergeThemesPerf.default 656 637 1.03:1
RadioGroupMinimalPerf.default 279 270 1.03:1
IconMinimalPerf.default 406 394 1.03:1
TableManyItemsPerf.default 1112 1084 1.03:1
CustomToolbarPrototype.default 1488 1443 1.03:1
CarouselMinimalPerf.default 260 254 1.02:1
ChatMinimalPerf.default 436 429 1.02:1
ChatWithPopoverPerf.default 199 195 1.02:1
LoaderMinimalPerf.default 187 183 1.02:1
ReactionMinimalPerf.default 213 209 1.02:1
SkeletonMinimalPerf.default 195 191 1.02:1
SliderMinimalPerf.default 740 728 1.02:1
BoxMinimalPerf.default 192 190 1.01:1
DatepickerMinimalPerf.default 3625 3588 1.01:1
HeaderMinimalPerf.default 215 212 1.01:1
ImageMinimalPerf.default 242 239 1.01:1
ListNestedPerf.default 333 329 1.01:1
ListWith60ListItems.default 374 372 1.01:1
RosterPerf.default 1605 1594 1.01:1
PopupMinimalPerf.default 354 349 1.01:1
ProviderMinimalPerf.default 198 197 1.01:1
StatusMinimalPerf.default 397 395 1.01:1
TreeWith60ListItems.default 88 87 1.01:1
AnimationMinimalPerf.default 312 312 1:1
DialogMinimalPerf.default 443 442 1:1
LayoutMinimalPerf.default 206 207 1:1
SplitButtonMinimalPerf.default 2239 2230 1:1
VideoMinimalPerf.default 435 436 1:1
DropdownMinimalPerf.default 1429 1450 0.99:1
LabelMinimalPerf.default 214 217 0.99:1
ListCommonPerf.default 405 408 0.99:1
ListMinimalPerf.default 300 303 0.99:1
ToolbarMinimalPerf.default 540 543 0.99:1
TooltipMinimalPerf.default 1251 1264 0.99:1
ButtonSlotsPerf.default 318 326 0.98:1
FormMinimalPerf.default 221 226 0.98:1
MenuMinimalPerf.default 500 512 0.98:1
MenuButtonMinimalPerf.default 963 979 0.98:1
PortalMinimalPerf.default 82 84 0.98:1
AlertMinimalPerf.default 151 155 0.97:1
ButtonOverridesMissPerf.default 651 668 0.97:1
HeaderSlotsPerf.default 457 469 0.97:1
TextMinimalPerf.default 188 194 0.97:1
FlexMinimalPerf.default 151 158 0.96:1
TextAreaMinimalPerf.default 289 302 0.96:1
TreeMinimalPerf.default 464 482 0.96:1
TableMinimalPerf.default 226 238 0.95:1
DividerMinimalPerf.default 197 213 0.92:1
AccordionMinimalPerf.default 79 92 0.86:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

📊 Bundle size report

✅ No changes found

@smhigley smhigley enabled auto-merge (squash) April 19, 2024 17:14
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 19, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 642 5000
Breadcrumb mount 1665 1717 1000
Checkbox mount 1714 1702 5000
CheckboxBase mount 1495 1489 5000
ChoiceGroup mount 2971 3034 5000
ComboBox mount 682 686 1000
CommandBar mount 6614 6632 1000
ContextualMenu mount 13575 12871 1000
DefaultButton mount 785 803 5000
DetailsRow mount 2243 2261 5000
DetailsRowFast mount 2237 2228 5000
DetailsRowNoStyles mount 2081 2079 5000
Dialog mount 2788 2793 1000
DocumentCardTitle mount 232 223 1000
Dropdown mount 1989 2046 5000
FocusTrapZone mount 1159 1144 5000
FocusZone mount 1081 1092 5000
GroupedList mount 42729 42604 2
GroupedList virtual-rerender 20781 20681 2
GroupedList virtual-rerender-with-unmount 59094 54264 2
GroupedListV2 mount 244 236 2
GroupedListV2 virtual-rerender 220 219 2
GroupedListV2 virtual-rerender-with-unmount 230 244 2
IconButton mount 1173 1177 5000
Label mount 348 362 5000
Layer mount 2838 2826 5000
Link mount 412 418 5000
MenuButton mount 989 1008 5000
MessageBar mount 22334 22301 5000
Nav mount 2089 2082 1000
OverflowSet mount 827 786 5000
Panel mount 1849 1896 1000
Persona mount 752 779 1000
Pivot mount 922 934 1000
PrimaryButton mount 948 943 5000
Rating mount 4834 4890 5000
SearchBox mount 953 938 5000
Shimmer mount 1960 1977 5000
Slider mount 1383 1391 5000
SpinButton mount 3053 3185 5000
Spinner mount 404 404 5000
SplitButton mount 1926 1886 5000
Stack mount 406 424 5000
StackWithIntrinsicChildren mount 896 890 5000
StackWithTextChildren mount 2682 2745 5000
SwatchColorPicker mount 6571 6651 5000
TagPicker mount 1546 1508 5000
Text mount 390 384 5000
TextField mount 957 980 5000
ThemeProvider mount 868 868 5000
ThemeProvider virtual-rerender 609 605 5000
ThemeProvider virtual-rerender-with-unmount 1328 1328 5000
Toggle mount 636 643 5000
buttonNative mount 203 205 5000

@smhigley smhigley merged commit 6075638 into microsoft:master Apr 19, 2024
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
@marcosmoura
Merge branch 'master' into feat/react-drawer/move-scroll-to-contex
456e2bf 
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
@marcosmoura
Merge branch 'master' into feat/react-drawer/move-scroll-to-context
033678b 
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@smhigley @miroslavstastny
feat: add accessibility docs to Link about color/underlines (microsof…
4cf775f 
…t#31121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

+1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

April Project Cycle Q1 2024

Development

Successfully merging this pull request may close these issues.

4 participants

@smhigley @fabricteam @khmakoto @ling1726