Fix wrong position of hover callout in case of single data AreaChart#30256
Merged
AtishayMsft merged 7 commits intomicrosoft:masterfrom Apr 23, 2024
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
📊 Bundle size report✅ No changes found |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 99abfca56172d60237607144d5e5250d442405f5 (build) |
AtishayMsft
reviewed
Jan 11, 2024
change/@fluentui-react-charting-4b4305e3-4ff3-49f0-88b1-d147b5063a05.json
Outdated
Show resolved
Hide resolved
AtishayMsft
reviewed
Jan 11, 2024
packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
|
Is there any blocking point in this PR? |
Gabnight
approved these changes
Apr 19, 2024
Gabnight
left a comment
There was a problem hiding this comment.
I approve, because if we have a point, we should always have an xAxis.
packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
…ix-wrong-pos-hover-callout-AreaChart
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AtishayMsft
reviewed
Apr 22, 2024
packages/react-charting/src/components/AreaChart/AreaChart.base.tsx
Outdated
Show resolved
Hide resolved
AtishayMsft
approved these changes
Apr 23, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Contributor
|
@Gabnight This PR is now merged and should be available in tomorrow's |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Wrong position of hover callout in case of single data point in AreaChart.
Cause:
Failing to set axisType for case where bisect() returns either d0 or d1 as undefined.
New Behavior
Related Issue(s)