fix: Table and DataGrid should not remove cells from the accessibility tree#31068
Merged
smhigley merged 5 commits intomicrosoft:masterfrom Apr 19, 2024
Merged
fix: Table and DataGrid should not remove cells from the accessibility tree#31068smhigley merged 5 commits intomicrosoft:masterfrom
smhigley merged 5 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 37 | 36 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 78 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 632 | 654 | 5000 | |
| Button | mount | 301 | 307 | 5000 | |
| Field | mount | 1145 | 1133 | 5000 | |
| FluentProvider | mount | 700 | 717 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 36 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 78 | 10 | Possible regression |
| MakeStyles | mount | 852 | 879 | 50000 | |
| Persona | mount | 1779 | 1771 | 5000 | |
| SpinButton | mount | 1422 | 1408 | 5000 | |
| SwatchPicker | mount | 1507 | 1540 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
ling1726
approved these changes
Apr 19, 2024
smhigley
commented
Apr 19, 2024
packages/react-components/react-table/stories/Table/SingleSelect.stories.tsx
Outdated
Show resolved
Hide resolved
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The header cell for the radio selection column was removed from the a11y tree via two separate mechanisms:
hiddenattribute was applied to the cell root, because of the Fluenthiddenprop of the same namevisibility: hiddenstyle was applied based on the hidden stateRemoving a cell from a table breaks the table structure, as well as screen reader table navigation, which resulted in a high-severity a11y bug.
New Behavior
While we could have made the Fluent
hiddenprop not apply that HTMLhiddenprop, that would also have meant that authors who intended to add the HTMLhiddenprop (e.g. to hide an entire column, and not just the header) would have been unable to.Instead, I deprecated
hiddenand added aninvisibleprop to do the same thing.Related Issue(s)