fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files#31087
Merged
Hotell merged 5 commits intomicrosoft:masterfrom Apr 23, 2024
Conversation
…ating 'show docs'
Hotell
commented
Apr 17, 2024
packages/react-components/react-tree/stories/Tree/TreeExpandIcon.stories.tsx
Show resolved
Hide resolved
Hotell
commented
Apr 17, 2024
packages/react-components/react-virtualizer/stories/Virtualizer/Dynamic.stories.tsx
Show resolved
Hide resolved
Collaborator
📊 Bundle size report✅ No changes found |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 678 | 648 | 5000 | |
| Button | mount | 322 | 319 | 5000 | |
| Field | mount | 1131 | 1124 | 5000 | |
| FluentProvider | mount | 704 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 37 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 80 | 10 | |
| MakeStyles | mount | 854 | 891 | 50000 | |
| Persona | mount | 1794 | 1742 | 5000 | |
| SpinButton | mount | 1396 | 1419 | 5000 | |
| SwatchPicker | mount | 1541 | 1548 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Hotell
commented
Apr 17, 2024
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 93 | 81 | 1.15:1 |
| ImageMinimalPerf.default | 231 | 214 | 1.08:1 |
| CardMinimalPerf.default | 322 | 300 | 1.07:1 |
| DropdownManyItemsPerf.default | 416 | 389 | 1.07:1 |
| RefMinimalPerf.default | 114 | 108 | 1.06:1 |
| TableMinimalPerf.default | 246 | 233 | 1.06:1 |
| FormMinimalPerf.default | 226 | 216 | 1.05:1 |
| InputMinimalPerf.default | 556 | 532 | 1.05:1 |
| ListNestedPerf.default | 323 | 309 | 1.05:1 |
| MenuMinimalPerf.default | 523 | 500 | 1.05:1 |
| SliderMinimalPerf.default | 761 | 728 | 1.05:1 |
| TreeMinimalPerf.default | 498 | 474 | 1.05:1 |
| AlertMinimalPerf.default | 165 | 158 | 1.04:1 |
| AnimationMinimalPerf.default | 310 | 299 | 1.04:1 |
| GridMinimalPerf.default | 191 | 183 | 1.04:1 |
| AvatarMinimalPerf.default | 112 | 109 | 1.03:1 |
| DividerMinimalPerf.default | 212 | 206 | 1.03:1 |
| PopupMinimalPerf.default | 348 | 338 | 1.03:1 |
| StatusMinimalPerf.default | 403 | 393 | 1.03:1 |
| TableManyItemsPerf.default | 1121 | 1092 | 1.03:1 |
| AttachmentMinimalPerf.default | 83 | 81 | 1.02:1 |
| AttachmentSlotsPerf.default | 664 | 650 | 1.02:1 |
| ButtonMinimalPerf.default | 91 | 89 | 1.02:1 |
| ChatWithPopoverPerf.default | 198 | 194 | 1.02:1 |
| HeaderMinimalPerf.default | 215 | 211 | 1.02:1 |
| LabelMinimalPerf.default | 224 | 220 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2262 | 2214 | 1.02:1 |
| VideoMinimalPerf.default | 460 | 450 | 1.02:1 |
| BoxMinimalPerf.default | 197 | 195 | 1.01:1 |
| ChatMinimalPerf.default | 442 | 438 | 1.01:1 |
| DialogMinimalPerf.default | 442 | 439 | 1.01:1 |
| FlexMinimalPerf.default | 159 | 157 | 1.01:1 |
| ListCommonPerf.default | 388 | 386 | 1.01:1 |
| ListMinimalPerf.default | 309 | 307 | 1.01:1 |
| ListWith60ListItems.default | 362 | 357 | 1.01:1 |
| SkeletonMinimalPerf.default | 193 | 191 | 1.01:1 |
| IconMinimalPerf.default | 376 | 371 | 1.01:1 |
| CarouselMinimalPerf.default | 259 | 258 | 1:1 |
| DatepickerMinimalPerf.default | 3605 | 3622 | 1:1 |
| DropdownMinimalPerf.default | 1445 | 1444 | 1:1 |
| LayoutMinimalPerf.default | 207 | 206 | 1:1 |
| ProviderMinimalPerf.default | 204 | 204 | 1:1 |
| SegmentMinimalPerf.default | 202 | 201 | 1:1 |
| ToolbarMinimalPerf.default | 543 | 541 | 1:1 |
| EmbedMinimalPerf.default | 1900 | 1924 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 720 | 724 | 0.99:1 |
| LoaderMinimalPerf.default | 183 | 185 | 0.99:1 |
| RadioGroupMinimalPerf.default | 257 | 259 | 0.99:1 |
| CustomToolbarPrototype.default | 1488 | 1506 | 0.99:1 |
| TooltipMinimalPerf.default | 1269 | 1278 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 161 | 164 | 0.98:1 |
| CheckboxMinimalPerf.default | 1141 | 1162 | 0.98:1 |
| MenuButtonMinimalPerf.default | 946 | 962 | 0.98:1 |
| RosterPerf.default | 1547 | 1579 | 0.98:1 |
| ReactionMinimalPerf.default | 216 | 221 | 0.98:1 |
| TreeWith60ListItems.default | 85 | 87 | 0.98:1 |
| AccordionMinimalPerf.default | 84 | 87 | 0.97:1 |
| HeaderSlotsPerf.default | 454 | 469 | 0.97:1 |
| ProviderMergeThemesPerf.default | 639 | 656 | 0.97:1 |
| TextMinimalPerf.default | 193 | 200 | 0.97:1 |
| ButtonOverridesMissPerf.default | 644 | 670 | 0.96:1 |
| ButtonSlotsPerf.default | 306 | 318 | 0.96:1 |
| TextAreaMinimalPerf.default | 277 | 288 | 0.96:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 642 | 650 | 5000 | |
| Breadcrumb | mount | 1669 | 1665 | 1000 | |
| Checkbox | mount | 1682 | 1678 | 5000 | |
| CheckboxBase | mount | 1435 | 1471 | 5000 | |
| ChoiceGroup | mount | 2934 | 3014 | 5000 | |
| ComboBox | mount | 663 | 643 | 1000 | |
| CommandBar | mount | 6173 | 6167 | 1000 | |
| ContextualMenu | mount | 11650 | 11601 | 1000 | |
| DefaultButton | mount | 751 | 757 | 5000 | |
| DetailsRow | mount | 2180 | 2176 | 5000 | |
| DetailsRowFast | mount | 2171 | 2229 | 5000 | |
| DetailsRowNoStyles | mount | 2008 | 2011 | 5000 | |
| Dialog | mount | 2713 | 2826 | 1000 | |
| DocumentCardTitle | mount | 219 | 217 | 1000 | |
| Dropdown | mount | 1963 | 1991 | 5000 | |
| FocusTrapZone | mount | 1146 | 1156 | 5000 | |
| FocusZone | mount | 1067 | 1093 | 5000 | |
| GroupedList | mount | 41618 | 41743 | 2 | |
| GroupedList | virtual-rerender | 20072 | 20090 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50334 | 50926 | 2 | |
| GroupedListV2 | mount | 218 | 215 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 216 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 240 | 222 | 2 | |
| IconButton | mount | 1103 | 1054 | 5000 | |
| Label | mount | 325 | 332 | 5000 | |
| Layer | mount | 2652 | 2743 | 5000 | |
| Link | mount | 387 | 369 | 5000 | |
| MenuButton | mount | 932 | 936 | 5000 | |
| MessageBar | mount | 21120 | 21369 | 5000 | |
| Nav | mount | 1913 | 1946 | 1000 | |
| OverflowSet | mount | 789 | 778 | 5000 | |
| Panel | mount | 1814 | 1775 | 1000 | |
| Persona | mount | 725 | 751 | 1000 | |
| Pivot | mount | 851 | 872 | 1000 | |
| PrimaryButton | mount | 836 | 859 | 5000 | |
| Rating | mount | 4543 | 4599 | 5000 | |
| SearchBox | mount | 909 | 918 | 5000 | |
| Shimmer | mount | 1867 | 1931 | 5000 | |
| Slider | mount | 1297 | 1264 | 5000 | |
| SpinButton | mount | 2837 | 2926 | 5000 | |
| Spinner | mount | 379 | 374 | 5000 | |
| SplitButton | mount | 1774 | 1826 | 5000 | |
| Stack | mount | 403 | 402 | 5000 | |
| StackWithIntrinsicChildren | mount | 858 | 848 | 5000 | |
| StackWithTextChildren | mount | 2568 | 2558 | 5000 | |
| SwatchColorPicker | mount | 6135 | 6139 | 5000 | |
| TagPicker | mount | 1453 | 1476 | 5000 | |
| Text | mount | 376 | 354 | 5000 | |
| TextField | mount | 936 | 954 | 5000 | |
| ThemeProvider | mount | 821 | 848 | 5000 | |
| ThemeProvider | virtual-rerender | 588 | 580 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1261 | 1259 | 5000 | |
| Toggle | mount | 610 | 603 | 5000 | |
| buttonNative | mount | 187 | 190 | 5000 |
bsunderhus
approved these changes
Apr 19, 2024
Contributor
bsunderhus
left a comment
There was a problem hiding this comment.
The react-dialog and react-tree LGTM ✅
ValentinaKozlova
approved these changes
Apr 19, 2024
Mitch-At-Work
approved these changes
Apr 19, 2024
marcosmoura
approved these changes
Apr 23, 2024
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 23, 2024
* master: (416 commits) fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087) Fix overlapping bars on continuous axes (microsoft#31035) feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116) feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086) applying package updates Sankey diagram: Support number formatting (microsoft#31113) Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256) Combobox filtering bug fix (microsoft#31141) chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114) docs: command cheat sheet (microsoft#30685) chore: refactor tests for createPresenceComponent() (microsoft#31137) Stable Release: TeachingPopover (microsoft#31112) applying package updates fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126) feat: add accessibility docs to Link about color/underlines (microsoft#31121) fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068) Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689) fix(react-swatch-picker): fixes after bug bash (microsoft#31097) feat: unify v9 babel preset in all packages (microsoft#31088) applying package updates ...
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…ating 'show docs' and circular dep imports from cypress files (microsoft#31087)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
relative imports are invalid/disallowed within
stories/New Behavior
react-componentssuite ( this will fail build once we migrate tolibrary/storiesprojects )Related Issue(s)