Skip to content

Make KBM Editor pinnable#46482

Merged
DHowett merged 1 commit intomainfrom
niels9001/kbm-pin
Mar 24, 2026
Merged

Make KBM Editor pinnable#46482
DHowett merged 1 commit intomainfrom
niels9001/kbm-pin

Conversation

@niels9001
Copy link
Copy Markdown
Collaborator

Summary of the Pull Request

Make the new KBM Editor command pinnable to the Dock

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copy link
Copy Markdown
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes the new Keyboard Manager (KBM) Editor command pinnable by assigning it a stable command identifier.

Changes:

  • Assign a stable Id to OpenNewKeyboardManagerEditorCommand when creating the ListItem.

Copy link
Copy Markdown
Contributor

@Jaylyn-Barbee Jaylyn-Barbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving copilot change

@Jaylyn-Barbee
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett closed this Mar 24, 2026
@DHowett DHowett reopened this Mar 24, 2026
@DHowett DHowett merged commit 107bf38 into main Mar 24, 2026
20 of 24 checks passed
zateutsch added a commit that referenced this pull request Mar 25, 2026
Cherry-picked commits:
- Make KBM Editor pinnable (#46482)
- CmdPal: Fix missing primary context command for late-bound items (#46131)
- CmdPal: Ensure DockWindow property cleans up after itself (#46303)
- CmdPal: Hotfix commonCallbacks array initial count to prevent negative number (#46215)
- CmdPal: Fix missing app context menu actions on the main page (#46293)
- CmdPal: Fix dock popup XamlRoot handling on DockControl (#46305)
- CmdPal: Reduce DockWindow backdrop switching and visual artifacts (#46309)
- Always On Top: The opacity should be able to configure the hotkey individually (#46410)
- [OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page (#46203)
- CmdPal: Fix scroller scrolling and down glyph (#46447)
- [Settings] Decouple Settings.UI.Library from PowerDisplay.Lib to fix (#46325)
@zateutsch zateutsch added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.98.1 Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants