Skip to content

CmdPal: Hotfix commonCallbacks array initial count to prevent negative number#46215

Merged
zadjii-msft merged 6 commits intomainfrom
dev/jpolasek/b/46210-cmdpal-fix-more-fallbacks-than-commands
Mar 24, 2026
Merged

CmdPal: Hotfix commonCallbacks array initial count to prevent negative number#46215
zadjii-msft merged 6 commits intomainfrom
dev/jpolasek/b/46210-cmdpal-fix-more-fallbacks-than-commands

Conversation

@jiripolasek
Copy link
Copy Markdown
Collaborator

@jiripolasek jiripolasek commented Mar 18, 2026

Summary of the Pull Request

This PR ensures that requested initial capacity is not a negative number. TopLevelCommandManager.TopLevelCommands state is not is sync with globalFallbacks here, plus globalFallbacks includes providers that are disabled.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jiripolasek jiripolasek self-assigned this Mar 18, 2026
@jiripolasek jiripolasek added Product-Command Palette Refers to the Command Palette utility 0.98.1 labels Mar 18, 2026
@jiripolasek jiripolasek marked this pull request as ready for review March 18, 2026 11:03
@jiripolasek jiripolasek requested review from michaeljolley and zadjii-msft and removed request for zadjii-msft March 18, 2026 11:03
Copy link
Copy Markdown
Contributor

@michaeljolley michaeljolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Image

@zateutsch zateutsch requested a review from michaeljolley March 24, 2026 18:09
@zadjii-msft zadjii-msft enabled auto-merge (squash) March 24, 2026 18:37
@zadjii-msft zadjii-msft merged commit 6cf1d32 into main Mar 24, 2026
15 checks passed
@jiripolasek jiripolasek deleted the dev/jpolasek/b/46210-cmdpal-fix-more-fallbacks-than-commands branch March 24, 2026 21:18
zateutsch added a commit that referenced this pull request Mar 25, 2026
Cherry-picked commits:
- Make KBM Editor pinnable (#46482)
- CmdPal: Fix missing primary context command for late-bound items (#46131)
- CmdPal: Ensure DockWindow property cleans up after itself (#46303)
- CmdPal: Hotfix commonCallbacks array initial count to prevent negative number (#46215)
- CmdPal: Fix missing app context menu actions on the main page (#46293)
- CmdPal: Fix dock popup XamlRoot handling on DockControl (#46305)
- CmdPal: Reduce DockWindow backdrop switching and visual artifacts (#46309)
- Always On Top: The opacity should be able to configure the hotkey individually (#46410)
- [OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page (#46203)
- CmdPal: Fix scroller scrolling and down glyph (#46447)
- [Settings] Decouple Settings.UI.Library from PowerDisplay.Lib to fix (#46325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.98.1 Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CmdPal crash: During a search, List<T>(capacity) in MainListPage.UpdateSearchTextCore received a negative capacity.

4 participants