CmdPal: Ensure DockWindow property cleans up after itself#46303
Merged
zadjii-msft merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
- Disposes its ViewModel (which it creates). - Unregisters itself explicitly from WeakReferenceMessenger. - Ensures that ShellPage closes the dock window when disposed and can't spawn more.
zadjii-msft
approved these changes
Mar 20, 2026
…ed-dock-window-from-messanger
zateutsch
approved these changes
Mar 24, 2026
zadjii-msft
approved these changes
Mar 24, 2026
…ed-dock-window-from-messanger
michaeljolley
approved these changes
Mar 24, 2026
zateutsch
added a commit
that referenced
this pull request
Mar 25, 2026
Cherry-picked commits: - Make KBM Editor pinnable (#46482) - CmdPal: Fix missing primary context command for late-bound items (#46131) - CmdPal: Ensure DockWindow property cleans up after itself (#46303) - CmdPal: Hotfix commonCallbacks array initial count to prevent negative number (#46215) - CmdPal: Fix missing app context menu actions on the main page (#46293) - CmdPal: Fix dock popup XamlRoot handling on DockControl (#46305) - CmdPal: Reduce DockWindow backdrop switching and visual artifacts (#46309) - Always On Top: The opacity should be able to configure the hotkey individually (#46410) - [OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page (#46203) - CmdPal: Fix scroller scrolling and down glyph (#46447) - [Settings] Decouple Settings.UI.Library from PowerDisplay.Lib to fix (#46325)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR improves cleanup of DockWindow after itself (since it can be created and destroyed multiple times during app lifetime).
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed