Skip to content

[OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page#46203

Merged
niels9001 merged 1 commit intomicrosoft:mainfrom
daverayment:fix/scoobe-open-settings-blank
Mar 24, 2026
Merged

[OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page#46203
niels9001 merged 1 commit intomicrosoft:mainfrom
daverayment:fix/scoobe-open-settings-blank

Conversation

@daverayment
Copy link
Copy Markdown
Collaborator

@daverayment daverayment commented Mar 18, 2026

Summary of the Pull Request

This PR fixes an issue where selecting the Settings button on the What's New page for a new or upgraded installation of PowerToys would show the Settings application but with a blank contents page instead of the Home page.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

When the current version of PowerToys doesn't match the last_version_run, the What's New (SCOOBE) page is displayed. The Settings page is loaded at the same time in a hidden state.

If the user selects the Settings button in the bottom-left of the What's New page, OpenSettingsItem_Tapped() is called, which calls:

App.OpenSettingsWindow();

This unhides the Settings window, but Settings has not navigated to an initial page, resulting in a blank display.

The solution is to instead call:

App.OpenSettingsWindow(ensurePageIsSelected: true);

Validation Steps Performed

Manual tests, following the instructions given in the original issue, i.e. setting the last_version_run JSON manually and retrying to simulate the upgrade/new install.

@daverayment daverayment requested a review from niels9001 March 18, 2026 06:16
@daverayment daverayment added Area-User Interface things that regard UX for PowerToys Area-OOBE First time run experience for users labels Mar 18, 2026
Copy link
Copy Markdown
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Looks like we only tested it my manually opening the scoobe window hence we didn't catch it!

@niels9001 niels9001 enabled auto-merge (squash) March 24, 2026 15:40
@niels9001
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@niels9001 niels9001 merged commit fa78cc8 into microsoft:main Mar 24, 2026
11 checks passed
zateutsch added a commit that referenced this pull request Mar 25, 2026
Cherry-picked commits:
- Make KBM Editor pinnable (#46482)
- CmdPal: Fix missing primary context command for late-bound items (#46131)
- CmdPal: Ensure DockWindow property cleans up after itself (#46303)
- CmdPal: Hotfix commonCallbacks array initial count to prevent negative number (#46215)
- CmdPal: Fix missing app context menu actions on the main page (#46293)
- CmdPal: Fix dock popup XamlRoot handling on DockControl (#46305)
- CmdPal: Reduce DockWindow backdrop switching and visual artifacts (#46309)
- Always On Top: The opacity should be able to configure the hotkey individually (#46410)
- [OOBE] Ensure the Settings button on the SCOOBE page opens Home, not a blank page (#46203)
- CmdPal: Fix scroller scrolling and down glyph (#46447)
- [Settings] Decouple Settings.UI.Library from PowerDisplay.Lib to fix (#46325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.98.1 Area-OOBE First time run experience for users Area-User Interface things that regard UX for PowerToys

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OOBE] The What's New page's Settings link opens a blank contents page in Settings

2 participants