β¨ feat(portal): embed thread chat in document preview portal#15216
Conversation
Embed FloatingChatPanel at the bottom of the Document preview portal so
users can converse with the agent about the document they are viewing
without leaving the portal.
Key changes:
- Remove the unused `/agent/:aid/:topicId/page/:docId` route and its
supporting modules (TopicCanvas, Page, PageRedirect, topicPageRouteMeta,
`agent/page` redirect). The route had no remaining UI entry point.
- Revive FloatingChatPanel as a thread-scoped side chat. Replace the
hardcoded MainChatInput with `@/features/Conversation`'s ChatInput so
the embedded composer no longer fights the main-page input for the
global `mainInputEditor` slot.
- Default the panel's context to `scope='thread' + isNew: true` so a
fresh ephemeral thread can be created on first send.
- Thread an `agentDocumentId` field through ConversationContext,
ExecAgentAppContext, the Document portal payload, `openDocument` and
callers (AgentDocumentsGroup, DocumentExplorerTree,
AgentSignalReceiptList) so the in-portal chat always knows the
agent_documents row id for the document in view.
- Rewrite the server `activeTopicDocument` resolver to use a single
indexed `findRowByDocumentId(agentId, documentId)` lookup. This
validates any caller-supplied row id and recovers the row when one
was not provided, fixing cross-topic documents (skills, web docs)
whose row id was previously missing β preventing the LLM from passing
a `documents.id` into `readDocument({ id })` and triggering a failed
query against `agent_documents.id`.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## canary #15216 +/- ##
==========================================
- Coverage 70.93% 70.91% -0.03%
==========================================
Files 3153 3146 -7
Lines 314705 314202 -503
Branches 28660 28613 -47
==========================================
- Hits 223240 222809 -431
+ Misses 91296 91224 -72
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b16b1a9cd
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Anchor the in-portal `FloatingChatPanel` on the topic's last main-scope
message so the first send goes through `conversationLifecycle.ts`'s
`newThread` branch and the server actually creates a thread row. The
resulting thread now shows up in the left sidebar's `ThreadList` under
the parent topic.
- Read `sourceMessageId` from the latest non-thread message in
`dbMessagesMap[messageMapKey({ agentId, topicId })]`; pair it with
`ThreadType.Standalone` in the conversation context when `isNew`.
- Track the active thread in panel-local state. On
`onAfterMessageCreate({ createdThreadId })` we refresh threads /
messages and pivot the context from `isNew` to the persisted
`threadId` in place β without calling `openThreadInPortal`, which
would push a Thread view onto the portal stack and cover the document
the user is reading.
- When the topic has no messages yet (no anchor), fall back to the
previous ephemeral behavior (still leaks to main on first send;
needed for empty-topic scenarios).
Make the Document portal's `FloatingChatPanel` a truly doc-anchored side
conversation β independent of the main topic history and surviving the
mid-send pivot from `_new` β persisted thread key without the AI stream
disappearing.
- Subscribe to `chatStore.portalThreadId` instead of a panel-local
`internalThreadId`. `lifecycle.ts:syncThreadInPortal` writes the new
thread id into the portal slice *before* stream chunks arrive, so this
panel's chatKey pivots in time to render the streaming response β the
old `onAfterMessageCreate` hook only fired after the stream resolved,
leaving the panel blank for the whole turn.
- Clear any stale `portalThreadId` left by a sibling portal on mount so a
fresh `(agentId, topicId, documentId)` opens in `isNew` state.
- Pass `skipFetch` + a filtered `messages` prop to ConversationProvider.
Without `skipFetch` the provider's own `useFetchMessages` pulled the
main-topic history into this panel; with the doc-anchored A-mode we
show only rows whose `threadId` matches the active thread (or nothing
before the first send).
- Split `openThreadInPortal` into two actions: keep the original (push
Thread view + sync state) for the main-page "create subtopic" flow,
and add `syncThreadInPortal` that only mutates the portal slice.
`lifecycle.ts` now picks one based on the current portal view type so a
panel-hosted ConversationProvider in the Document portal no longer
triggers a Thread view that covers the document.
- Add `key={agentId:topicId:documentId}` on `FloatingChatPanel` inside
`Portal/Document/Body.tsx` so panel-local state (snap point, open,
etc.) resets when conversation coordinates change.
- Anchor new threads on the topic's last main-scope message, paired with
`ThreadType.Standalone`, so first send actually creates a thread row
rather than leaking into the main topic.
β¦#15216) * β¨ feat(portal): embed thread chat in document preview portal Embed FloatingChatPanel at the bottom of the Document preview portal so users can converse with the agent about the document they are viewing without leaving the portal. Key changes: - Remove the unused `/agent/:aid/:topicId/page/:docId` route and its supporting modules (TopicCanvas, Page, PageRedirect, topicPageRouteMeta, `agent/page` redirect). The route had no remaining UI entry point. - Revive FloatingChatPanel as a thread-scoped side chat. Replace the hardcoded MainChatInput with `@/features/Conversation`'s ChatInput so the embedded composer no longer fights the main-page input for the global `mainInputEditor` slot. - Default the panel's context to `scope='thread' + isNew: true` so a fresh ephemeral thread can be created on first send. - Thread an `agentDocumentId` field through ConversationContext, ExecAgentAppContext, the Document portal payload, `openDocument` and callers (AgentDocumentsGroup, DocumentExplorerTree, AgentSignalReceiptList) so the in-portal chat always knows the agent_documents row id for the document in view. - Rewrite the server `activeTopicDocument` resolver to use a single indexed `findRowByDocumentId(agentId, documentId)` lookup. This validates any caller-supplied row id and recovers the row when one was not provided, fixing cross-topic documents (skills, web docs) whose row id was previously missing β preventing the LLM from passing a `documents.id` into `readDocument({ id })` and triggering a failed query against `agent_documents.id`. * β¨ feat(portal): persist document portal chats as real threads Anchor the in-portal `FloatingChatPanel` on the topic's last main-scope message so the first send goes through `conversationLifecycle.ts`'s `newThread` branch and the server actually creates a thread row. The resulting thread now shows up in the left sidebar's `ThreadList` under the parent topic. - Read `sourceMessageId` from the latest non-thread message in `dbMessagesMap[messageMapKey({ agentId, topicId })]`; pair it with `ThreadType.Standalone` in the conversation context when `isNew`. - Track the active thread in panel-local state. On `onAfterMessageCreate({ createdThreadId })` we refresh threads / messages and pivot the context from `isNew` to the persisted `threadId` in place β without calling `openThreadInPortal`, which would push a Thread view onto the portal stack and cover the document the user is reading. - When the topic has no messages yet (no anchor), fall back to the previous ephemeral behavior (still leaks to main on first send; needed for empty-topic scenarios). * β¨ feat(portal): isolate document portal thread chat from main topic Make the Document portal's `FloatingChatPanel` a truly doc-anchored side conversation β independent of the main topic history and surviving the mid-send pivot from `_new` β persisted thread key without the AI stream disappearing. - Subscribe to `chatStore.portalThreadId` instead of a panel-local `internalThreadId`. `lifecycle.ts:syncThreadInPortal` writes the new thread id into the portal slice *before* stream chunks arrive, so this panel's chatKey pivots in time to render the streaming response β the old `onAfterMessageCreate` hook only fired after the stream resolved, leaving the panel blank for the whole turn. - Clear any stale `portalThreadId` left by a sibling portal on mount so a fresh `(agentId, topicId, documentId)` opens in `isNew` state. - Pass `skipFetch` + a filtered `messages` prop to ConversationProvider. Without `skipFetch` the provider's own `useFetchMessages` pulled the main-topic history into this panel; with the doc-anchored A-mode we show only rows whose `threadId` matches the active thread (or nothing before the first send). - Split `openThreadInPortal` into two actions: keep the original (push Thread view + sync state) for the main-page "create subtopic" flow, and add `syncThreadInPortal` that only mutates the portal slice. `lifecycle.ts` now picks one based on the current portal view type so a panel-hosted ConversationProvider in the Document portal no longer triggers a Thread view that covers the document. - Add `key={agentId:topicId:documentId}` on `FloatingChatPanel` inside `Portal/Document/Body.tsx` so panel-local state (snap point, open, etc.) resets when conversation coordinates change. - Anchor new threads on the topic's last main-scope message, paired with `ThreadType.Standalone`, so first send actually creates a thread row rather than leaking into the main topic.
# π LobeHub Release (20260528) **Release Date:** May 28, 2026 **Since v2.2.0:** 220 merged PRs Β· 15 contributors > This cycle brings heterogeneous "platform agents" you can dispatch to local or remote devices, a rebuilt onboarding flow, document-centric chat, and a unified model-runtime error model β with new DeepSeek V4 and Gemini 3.5 Flash support along the way. --- ## β¨ Highlights - **More Hetero Agents (OpenClaw / Hermes)** β Create heterogeneous agents and dispatch them to local or remote devices through the device gateway, with an execution-target switcher in the composer and persistent CLI sessions. (#15065, #15179, #15022) - **iMessage on Desktop** β New iMessage setup and bridge on desktop, plus bot attachments across every platform. (#15228, #15227, #15029) - **Skills in the Composer** β Drag skill chips into chat, trigger installed skills from the slash menu mid-line, and surface project-level skills in the homogeneous agent runtime. (#15095, #15061, #15110) - **New Models** β DeepSeek V4 Flash/Pro and Gemini 3.5 Flash across providers, with thinking params for structured output and chat cost estimates. (#15031, #15001, #15051, #14876) - **Agent Runtime Observability** β OpenTelemetry GenAI semantic conventions plus per-call generation tracing. (#15123, #15124) --- ## π€ Agents & Heterogeneous Runtime - **Platform agent creation** β OpenClaw/Hermes creation UI, device guard, and remote dispatch backend. (#15065) - **Execution-target switcher** β Pick local vs remote execution directly in the composer; device-selection UX with actionable guidance. (#15179, #15111) - **CLI hetero dispatch** β OpenClaw/Hermes dispatch with persistent sessions and a notify protocol. (#15022) - **Gateway snapshot as source of truth** β Consume the gateway `uiMessages` snapshot at step boundaries to keep chat state consistent. (#15153, #15152) - **Client sub-agent as a normal tool call** β Simplifies the sub-agent execution path. (#15281) - **Hermes agent chain** β Implements the Hermes agent chain logic. (#15189) - **Device registry** β TRPC endpoints to register, list, update, and remove devices. (#15299) - **Desktop device routing** β Route gateway agent runs through `lh hetero exec`; restore `userId` in gateway dispatch and gate local-system by execution target. (#15132, #15232) - **Agent signals** β Anchor agent-signal receipts to messages and isolate memory-agent messages into a child thread. (#14969, #14921) --- ## π Onboarding - **Simplified first screen** β Defer topic creation to first send. (#15090) - **Market Agent Picker** β Added as a classic onboarding step, with template prefetch. (#14980, #15041) - **Welcome guidance** β Show agent welcome guidance on first run. (#15098) - **Mobile** β Adapt agent onboarding UI and restore Classic-step padding on mobile. (#15019, #15032) - **Discovery** β Streamline discovery to a single profession question. (#14987) - **Analytics** β Track onboarding step events and create-agent modal source. (#15133, #15028) --- ## π Documents, Pages & Knowledge - **Thread chat in preview** β Embed thread chat in the document preview portal. (#15216) - **Non-markdown rendering** β Render non-markdown docs as a read-only highlight. (#15272) - **Multi-select** β Multi-select delete in the document tree. (#15125) - **Page-agent streaming** β Preview `initPage` streaming arguments. (#15039) - **Per-agent topics** β Per-agent topic management page. (#15207) - **Server-side category** β Derive document category server-side and drop frontend predicates. (#15076) --- ## π§© Skills & Tools - **Drag skill chips** β Drag skills into chat input and register agent-document skills. (#15095) - **Slash menu** β Installed skills appear in the slash menu with a mid-line trigger. (#15061) - **Project skills** β Recognize project-level skills in the homogeneous agent runtime and surface them regardless of active device. (#15110, #15177) - **VFS archiving** β Archive oversized tool results to VFS instead of truncating. (#15074) - **@localfile mentions** β Drag folders into chat input as `@localFile` mentions on desktop. (#15071) --- ## π§ Model Runtime & Providers - **Error spec registry** β Unify error codes into a spec + pattern registry, split `ProviderBizError` into finer codes, classify Cloud-only codes via a tier digit, and add `DatabasePersistError`. (#15262, #15286, #15278, #15279) - **New models** β DeepSeek V4 Flash/Pro (opencode-go) and Gemini 3.5 Flash; DeepSeek V4 Pro on SiliconCloud. (#15031, #15001, #15017, #15267) - **Structured output** β Thinking params for structured output, Bedrock structured generation, and DeepSeek `generateObject` tool choice. (#15051, #15174, #15054) - **Cost** β Chat cost estimate support; preserve usage cost in custom streams. (#14876, #15218) --- ## π¬ Chat & User Experience - **Follow-up chips** β Extend follow-up chip suggestions to general chat with scene-specific model config. (#15101, #14797) - **Input drafts** β Persist unsent input drafts across tab switches and prevent repeated draft restore. (#14992, #15024) - **Command menu** β Order topic/message search by recency and promote inline type filters. (#15094, #14986) - **Zoom HUD** β Show a zoom-level HUD on Cmd +/β and Cmd 0. (#15294) - **Copy** β Unescape markdown escapes when copying user messages. (#15253) --- ## π₯οΈ Desktop - **App Nap fix** β Prevent App Nap from dropping the gateway WebSocket during display sleep. (#14994) - **File preview** β Preview `.cjs`/`.mjs`/no-extension files instead of binary fallback and expand `~` when opening local files. (#15168, #15284) - **Cross-platform settings** β Open settings via main-window navigation on Windows/Linux and restore the route after an update restart. (#15036, #14922) - **Token refresh** β Prevent frequent logout from token-refresh retries. (#14928) --- ## π Observability - **OTel GenAI** β Instrument Agent Runtime with OpenTelemetry GenAI semantic conventions. (#15123) - **Generation tracing** β Per-call `llm_generation_tracing` with a pre-allocated tracingId and recordFeedback router. (#15124, #15146) - **Error classification** β Persist `ERROR_CODE_SPECS` classification on operation errors. (#15273) --- ## ποΈ Database Migrations - **Batch migrations** β Topic usage stats, push tokens, `tasks.editor_data`, and document shares. (#15280) - **Tracing & eval tables** β Add `llm_generation_tracing` and agent eval experiment tables. (#15126) > Self-hosted operators should run the database migration (`pnpm db:migrate`, or restart with auto-migrate enabled) after upgrading. The changes are additive and backwards-compatible. --- ## π Security & Reliability - **Security:** Remove the `getPlaintextCred` tool to prevent plaintext credential exposure. (#14998) - **Security:** Prompt account selection for Google OAuth and add `prompt=consent` to the OIDC authorization URL to fix missing refresh tokens. (#15234, #15010) - **Reliability:** Preserve streamed content across a mid-stream cancel. (#15173) - **Reliability:** Bound the Redis command timeout and configure the Anthropic client timeout. (#15091, #15042) - **Reliability:** Prevent infinite recursion in the assistant chain. (#15288) --- ## π₯ Contributors Huge thanks to **15 contributors** who shipped **220 merged PRs** this cycle. @AnotiaWang Β· @sxjeru Β· @algojogacor Β· @hardy-one Β· @arvinxx Β· @Innei Β· @tjx666 Β· @lijian Β· @AmAzing129 Β· @rdmclin2 Β· @neko Β· @cy948 Β· @CanisMinor Β· @sudongyuer Β· @rivertwilight Plus @lobehubbot and renovate[bot] for maintenance. --- **Full Changelog**: v2.2.0...release/weekly-20260528
π» Change Type
π Related Issue
resolve LOBE-9537
π Description of Change
Embed
FloatingChatPanelat the bottom of the Document preview portal so users can converse with the agent about the document they are viewing without leaving the portal.Dead-code cleanup
/agent/:aid/:topicId/page/:docIdroute and its supporting modules:src/features/TopicCanvas/**,src/routes/(main)/agent/features/Page/**,src/routes/(main)/agent/features/topicPageRouteMeta.ts,src/routes/(main)/agent/page/index.tsx,src/routes/(main)/agent/[topicId]/page/**. The route had no remaining UI entry point.pageMatch/useMatchdead navigation branches fromDocumentExplorerTree,AgentDocumentsGroupandAgentSignalReceiptList(they only ever fired inside the now-removed route).agent-topic-pagemigration case inElectron/titlebar/TabBar/storage.ts(target URL no longer exists).Embedded portal chat
FloatingChatPanelas a thread-scoped side chat. Replace its hardcodedMainChatInputwith@/features/Conversation'sChatInput(mirrorsPortal/Thread/Chat) so the embedded composer no longer fights the main-page input for the globalmainInputEditorslot.scope='thread' + isNew: trueso a fresh ephemeral thread can be created on first send. Existing thread IDs still work via thethreadIdprop.src/features/Portal/Document/Body.tsx, wired to the active agent / topic and the portal's currentdocumentId/agentDocumentId.<document>context injection (cross-topic fix)agentDocumentIdfield toConversationContextandExecAgentAppContext. Extend the Document portal payload,openDocument(documentId, agentDocumentId?)action andchatPortalSelectors.portalAgentDocumentIdselector so portal openers can carry theagent_documentsrow id.AgentDocumentsGroup,DocumentExplorerTree,AgentSignalReceiptList) to pass the row id alongside the document id.activeTopicDocumentresolver inaiAgentto use a single indexedfindRowByDocumentId(agentId, documentId)lookup (newagentDocumentsServicewrapper). This validates any caller-supplied row id and recovers the row when one was not provided, fixing cross-topic documents (skills, web docs) whose row id was previously missing β preventing the LLM from passing adocuments.idintoreadDocument({ id })and triggering a failed query againstagent_documents.id.agentDocumentId, fall back to the existinglistDocuments({ scope: 'currentTopic' })lookup otherwise.Architectural notes
agentDocumentIdis silently corrected by the server's(agentId, documentId)lookup.sendwithout asourceMessageIdfalls through to the main topic rather than persisting as a real thread. Real thread persistence is a follow-up once the source-message anchor for document-scoped threads is defined.π§ͺ How to Test
Manual:
<document document_id agent_document_id title />block should now carryagent_document_ideven for skills / web docs that do not belong to the current topic. The LLM'sreadDocument({ id })tool calls should succeed (noFailed query select β¦ where agent_documents.id = 'docs_β¦')./agent/:aid/:topicId/page/:docIdURL 404s (route removed).Automated:
bun run type-checkβ green.πΈ Screenshots / Videos
<document>context injection.π Additional Information
ConversationContext.agentDocumentIdis additive and optional β existing callers continue to work unchanged.listDocumentsForTopic + findβfindByDocumentId) is also an O(1) win on the hot send path; the lookup uses the existing(agent_id, document_id)index path onagent_documents.