Skip to content

🐛 fix(agent-signal): isolate memory-agent messages into a child thread#14921

Merged
nekomeowww merged 2 commits into
canaryfrom
fix/agent-signal-memory-thread-isolation
May 18, 2026
Merged

🐛 fix(agent-signal): isolate memory-agent messages into a child thread#14921
nekomeowww merged 2 commits into
canaryfrom
fix/agent-signal-memory-thread-isolation

Conversation

@arvinxx

@arvinxx arvinxx commented May 18, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

Memory-agent messages generated by runMemoryActionAgent were being written directly into the triggering topic, polluting the main conversation timeline.

Root cause: createOperation's appContext only carried topicId — no threadId or sourceMessageId — so RuntimeExecutors.messageModel.create() flattened every message into the main topic.

Fix:

  • Add optional sourceMessageId to runMemoryActionAgent input and memoryActionRunner interface
  • Before createOperation, when both topicId and sourceMessageId are present, create a ThreadType.Isolation child thread anchored to the triggering assistant message via ThreadModel.create()
  • Pass threadId + sourceMessageId through appContext so RuntimeExecutors stamps every persisted message with the correct thread scope
  • In handleUserMemoryAction, extract assistantMessageId (fallback messageId) from action payload and forward it as sourceMessageId
  • Thread creation is non-fatal: failures fall back to existing behaviour (write into main topic)

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

Trigger a memory-write signal and confirm that the resulting messages appear as a child thread under the assistant message rather than as top-level messages in the topic.

📸 Screenshots / Videos

Before After
Memory-agent messages appear inline in the main topic Memory-agent messages are isolated in a child thread under the triggering assistant message

📝 Additional Information

Only is touched (41-line change).

@vercel

vercel Bot commented May 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment May 18, 2026 6:30am

Request Review

@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. feature:memory Memory feature feature:thread subtopic / thread labels May 18, 2026
@lobehubbot

Copy link
Copy Markdown
Member

👋 Thanks for your contribution!

This PR currently targets the main branch, but main is reserved for release PRs only. Day-to-day development (features, fixes, refactors, docs, etc.) should target the canary branch.

How to fix

On the PR page, click Edit next to the title, then change the base branch from main to canary.

When targeting main is allowed

  • PR title starts with 🚀 release: v{x.y.z} (minor release)
  • Head branch matches hotfix/* or release/* (patch release)

If your PR fits one of these cases, please ignore this message.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8719cb803

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/server/services/agentSignal/policies/analyzeIntent/actions/userMemory.ts Outdated
@nekomeowww nekomeowww changed the title fix(agent-signal): isolate memory-agent messages into a child thread 🐛 fix(agent-signal): isolate memory-agent messages into a child thread May 18, 2026
@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.71429% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.94%. Comparing base (6f42386) to head (5ba3bcd).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #14921      +/-   ##
==========================================
- Coverage   65.94%   65.94%   -0.01%     
==========================================
  Files        2976     2976              
  Lines      263041   263075      +34     
  Branches    26775    31288    +4513     
==========================================
+ Hits       173463   173478      +15     
- Misses      89417    89436      +19     
  Partials      161      161              
Flag Coverage Δ
app 60.69% <45.71%> (-0.01%) ⬇️
database 91.96% <ø> (ø)
packages/agent-runtime 80.48% <ø> (ø)
packages/builtin-tool-lobe-agent 18.33% <ø> (ø)
packages/context-engine 83.92% <ø> (ø)
packages/conversation-flow 91.28% <ø> (ø)
packages/file-loaders 87.84% <ø> (ø)
packages/memory-user-memory 75.01% <ø> (ø)
packages/model-bank 99.94% <ø> (ø)
packages/model-runtime 83.93% <ø> (ø)
packages/prompts 71.60% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/types 13.03% <ø> (ø)
packages/utils 87.98% <ø> (ø)
packages/web-crawler 87.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.32% <ø> (ø)
Services 53.79% <ø> (ø)
Server 71.90% <45.71%> (-0.02%) ⬇️
Libs 56.16% <ø> (ø)
Utils 82.65% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx changed the base branch from main to canary May 18, 2026 06:09
@arvinxx arvinxx force-pushed the fix/agent-signal-memory-thread-isolation branch from fffb3ee to 93a573c Compare May 18, 2026 06:12
arvinxx added 2 commits May 18, 2026 14:16
When runMemoryActionAgent fires, all messages produced by the mini
agent runtime (user prompt + tool calls + assistant reply) were being
written directly into the triggering topic, polluting the main
conversation timeline.

Fix:
- Accept an optional  in  and
  .
- Before starting the AgentRuntime operation, create a
   thread anchored to  so the
  memory-agent messages live under that message's sub-thread.
- Pass  and  through  so
  RuntimeExecutors stamps every persisted message with the correct
  thread scope.
- In , extract  (falling
  back to ) from the action payload and forward it as
   to the runner.
- Thread creation is non-fatal: if it fails the agent falls back to
  writing into the main topic (existing behaviour).
…ad correctly

The previous fix fell back to messageId (the user message) when
assistantMessageId was absent from the action payload, causing the
isolation thread to be anchored to the wrong chat item.

Root cause:
- clientRuntimeComplete hydration sets source.payload.messageId to the
  parent user message id; it does not add assistantMessageId to the
  agentUserMessage source payload (field not in the shared type).
- planUserMemory copied only messageId into the action payload, so
  handleUserMemoryAction never received a reliable assistant message id.

Fix:
- Add extractAssistantMessageIdFromSourceId() in processors/actions.ts.
  Hydration produces sourceIds in the form
  `${assistantMessageId}:completion:${parentMessageId}`; parsing that
  suffix recovers the assistant message id without touching the shared
  agent-signal package types.
- planUserMemory now writes assistantMessageId into the action payload
  from the parsed source id. For non-clientRuntimeComplete sources the
  field is undefined and no thread anchoring takes place.
- handleUserMemoryAction drops the messageId fallback: sourceMessageId
  is only set when assistantMessageId is present, ensuring the child
  thread is always anchored to the assistant message boundary or not
  created at all.
@arvinxx arvinxx force-pushed the fix/agent-signal-memory-thread-isolation branch from 93a573c to 5ba3bcd Compare May 18, 2026 06:17
@nekomeowww nekomeowww merged commit 652005e into canary May 18, 2026
34 of 35 checks passed
@nekomeowww nekomeowww deleted the fix/agent-signal-memory-thread-isolation branch May 18, 2026 06:47
@arvinxx arvinxx mentioned this pull request May 28, 2026
arvinxx added a commit that referenced this pull request May 29, 2026
# 🚀 LobeHub Release (20260528)

**Release Date:** May 28, 2026  
**Since v2.2.0:** 220 merged PRs · 15 contributors

> This cycle brings heterogeneous "platform agents" you can dispatch to
local or remote devices, a rebuilt onboarding flow, document-centric
chat, and a unified model-runtime error model — with new DeepSeek V4 and
Gemini 3.5 Flash support along the way.

---

## ✨ Highlights

- **More Hetero Agents (OpenClaw / Hermes)** — Create heterogeneous
agents and dispatch them to local or remote devices through the device
gateway, with an execution-target switcher in the composer and
persistent CLI sessions. (#15065, #15179, #15022)
- **iMessage on Desktop** — New iMessage setup and bridge on desktop,
plus bot attachments across every platform. (#15228, #15227, #15029)
- **Skills in the Composer** — Drag skill chips into chat, trigger
installed skills from the slash menu mid-line, and surface project-level
skills in the homogeneous agent runtime. (#15095, #15061, #15110)
- **New Models** — DeepSeek V4 Flash/Pro and Gemini 3.5 Flash across
providers, with thinking params for structured output and chat cost
estimates. (#15031, #15001, #15051, #14876)
- **Agent Runtime Observability** — OpenTelemetry GenAI semantic
conventions plus per-call generation tracing. (#15123, #15124)

---

## 🤖 Agents & Heterogeneous Runtime

- **Platform agent creation** — OpenClaw/Hermes creation UI, device
guard, and remote dispatch backend. (#15065)
- **Execution-target switcher** — Pick local vs remote execution
directly in the composer; device-selection UX with actionable guidance.
(#15179, #15111)
- **CLI hetero dispatch** — OpenClaw/Hermes dispatch with persistent
sessions and a notify protocol. (#15022)
- **Gateway snapshot as source of truth** — Consume the gateway
`uiMessages` snapshot at step boundaries to keep chat state consistent.
(#15153, #15152)
- **Client sub-agent as a normal tool call** — Simplifies the sub-agent
execution path. (#15281)
- **Hermes agent chain** — Implements the Hermes agent chain logic.
(#15189)
- **Device registry** — TRPC endpoints to register, list, update, and
remove devices. (#15299)
- **Desktop device routing** — Route gateway agent runs through `lh
hetero exec`; restore `userId` in gateway dispatch and gate local-system
by execution target. (#15132, #15232)
- **Agent signals** — Anchor agent-signal receipts to messages and
isolate memory-agent messages into a child thread. (#14969, #14921)

---

## 🚀 Onboarding

- **Simplified first screen** — Defer topic creation to first send.
(#15090)
- **Market Agent Picker** — Added as a classic onboarding step, with
template prefetch. (#14980, #15041)
- **Welcome guidance** — Show agent welcome guidance on first run.
(#15098)
- **Mobile** — Adapt agent onboarding UI and restore Classic-step
padding on mobile. (#15019, #15032)
- **Discovery** — Streamline discovery to a single profession question.
(#14987)
- **Analytics** — Track onboarding step events and create-agent modal
source. (#15133, #15028)

---

## 📄 Documents, Pages & Knowledge

- **Thread chat in preview** — Embed thread chat in the document preview
portal. (#15216)
- **Non-markdown rendering** — Render non-markdown docs as a read-only
highlight. (#15272)
- **Multi-select** — Multi-select delete in the document tree. (#15125)
- **Page-agent streaming** — Preview `initPage` streaming arguments.
(#15039)
- **Per-agent topics** — Per-agent topic management page. (#15207)
- **Server-side category** — Derive document category server-side and
drop frontend predicates. (#15076)

---

## 🧩 Skills & Tools

- **Drag skill chips** — Drag skills into chat input and register
agent-document skills. (#15095)
- **Slash menu** — Installed skills appear in the slash menu with a
mid-line trigger. (#15061)
- **Project skills** — Recognize project-level skills in the homogeneous
agent runtime and surface them regardless of active device. (#15110,
#15177)
- **VFS archiving** — Archive oversized tool results to VFS instead of
truncating. (#15074)
- **@localfile mentions** — Drag folders into chat input as `@localFile`
mentions on desktop. (#15071)

---

## 🧠 Model Runtime & Providers

- **Error spec registry** — Unify error codes into a spec + pattern
registry, split `ProviderBizError` into finer codes, classify Cloud-only
codes via a tier digit, and add `DatabasePersistError`. (#15262, #15286,
#15278, #15279)
- **New models** — DeepSeek V4 Flash/Pro (opencode-go) and Gemini 3.5
Flash; DeepSeek V4 Pro on SiliconCloud. (#15031, #15001, #15017, #15267)
- **Structured output** — Thinking params for structured output, Bedrock
structured generation, and DeepSeek `generateObject` tool choice.
(#15051, #15174, #15054)
- **Cost** — Chat cost estimate support; preserve usage cost in custom
streams. (#14876, #15218)

---

## 💬 Chat & User Experience

- **Follow-up chips** — Extend follow-up chip suggestions to general
chat with scene-specific model config. (#15101, #14797)
- **Input drafts** — Persist unsent input drafts across tab switches and
prevent repeated draft restore. (#14992, #15024)
- **Command menu** — Order topic/message search by recency and promote
inline type filters. (#15094, #14986)
- **Zoom HUD** — Show a zoom-level HUD on Cmd +/− and Cmd 0. (#15294)
- **Copy** — Unescape markdown escapes when copying user messages.
(#15253)

---

## 🖥️ Desktop

- **App Nap fix** — Prevent App Nap from dropping the gateway WebSocket
during display sleep. (#14994)
- **File preview** — Preview `.cjs`/`.mjs`/no-extension files instead of
binary fallback and expand `~` when opening local files. (#15168,
#15284)
- **Cross-platform settings** — Open settings via main-window navigation
on Windows/Linux and restore the route after an update restart. (#15036,
#14922)
- **Token refresh** — Prevent frequent logout from token-refresh
retries. (#14928)

---

## 📊 Observability

- **OTel GenAI** — Instrument Agent Runtime with OpenTelemetry GenAI
semantic conventions. (#15123)
- **Generation tracing** — Per-call `llm_generation_tracing` with a
pre-allocated tracingId and recordFeedback router. (#15124, #15146)
- **Error classification** — Persist `ERROR_CODE_SPECS` classification
on operation errors. (#15273)

---

## 🗃️ Database Migrations

- **Batch migrations** — Topic usage stats, push tokens,
`tasks.editor_data`, and document shares. (#15280)
- **Tracing & eval tables** — Add `llm_generation_tracing` and agent
eval experiment tables. (#15126)

> Self-hosted operators should run the database migration (`pnpm
db:migrate`, or restart with auto-migrate enabled) after upgrading. The
changes are additive and backwards-compatible.

---

## 🔒 Security & Reliability

- **Security:** Remove the `getPlaintextCred` tool to prevent plaintext
credential exposure. (#14998)
- **Security:** Prompt account selection for Google OAuth and add
`prompt=consent` to the OIDC authorization URL to fix missing refresh
tokens. (#15234, #15010)
- **Reliability:** Preserve streamed content across a mid-stream cancel.
(#15173)
- **Reliability:** Bound the Redis command timeout and configure the
Anthropic client timeout. (#15091, #15042)
- **Reliability:** Prevent infinite recursion in the assistant chain.
(#15288)

---

## 👥 Contributors

Huge thanks to **15 contributors** who shipped **220 merged PRs** this
cycle.

@AnotiaWang · @sxjeru · @algojogacor · @hardy-one · @arvinxx · @Innei ·
@tjx666 · @lijian · @AmAzing129 · @rdmclin2 · @neko · @cy948 ·
@CanisMinor · @sudongyuer · @rivertwilight

Plus @lobehubbot and renovate[bot] for maintenance.

---

**Full Changelog**: v2.2.0...release/weekly-20260528
@dosubot dosubot Bot mentioned this pull request May 30, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:memory Memory feature feature:thread subtopic / thread size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants