Skip to content

✨ feat: drag folders into chat input as @localFile mentions on desktop#15071

Merged
Innei merged 1 commit into
canaryfrom
feat/drag-folder-as-mention
May 21, 2026
Merged

✨ feat: drag folders into chat input as @localFile mentions on desktop#15071
Innei merged 1 commit into
canaryfrom
feat/drag-folder-as-mention

Conversation

@Innei

@Innei Innei commented May 21, 2026

Copy link
Copy Markdown
Member

πŸ’» Change Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ‘· build
  • ⚑️ perf
  • βœ… test
  • πŸ“ docs
  • πŸ”¨ chore

πŸ”— Related Issue

N/A

πŸ”€ Description of Change

On desktop, when the agent's runtime mode is local (or it's a heterogeneous agent), dragging a folder into the chat input now inserts a <localFile path="..." isDirectory /> mention at the editor cursor instead of recursively uploading all its contents.

Mixed drops (folder + file) split cleanly: folders insert mentions in drop order, files flow to the existing upload pipeline in parallel.

Drag overlay detects content kind on dragenter via webkitGetAsEntry() and swaps the icon + title + description:

  • All files β†’ existing "Upload Files" hint (unchanged)
  • All folders β†’ new "Reference Folder" hint with folder icon
  • Mixed β†’ new "Reference Folder & Upload Files" hint

Path resolution uses window.electron.webUtils.getPathForFile(directoryFile) (exposed by @electron-toolkit/preload). If Electron isn't available or path resolution fails, the folder falls back to the legacy recurse-and-upload behavior so users aren't silently dropped.

Gate alignment (refactor): the same condition isLocalSystemEnabled || isHeterogeneous is now used in three places where the previous lobe-local-system plugin check was misleading:

  1. useLocalFileMention.desktop.ts β€” @ menu's local file search
  2. conversationLifecycle.ts β€” server-side canMaterializeLocalFiles gate
  3. New folder-drop trigger in agent Conversation/index.tsx

This is correct because src/helpers/toolEngineering/index.ts:158 already overrides the user-plugin selection for LocalSystemManifest with isLocalSystemEnabled β€” so runtime mode (runtimeMode === 'local', default on desktop) is the only real gate. The plugin-presence checks were dead conditions.

New files:

  • src/components/DragUploadZone/useLocalDragUpload.test.ts β€” 11 cases covering detectDragContentKind + partitionDroppedItems (folders, files, mixed, non-file kinds, Electron fallback)
  • src/features/ChatInput/InputEditor/insertLocalFolderMentions.ts β€” focuses the editor and dispatches INSERT_MENTION_COMMAND per folder with a space between consecutive mentions and a trailing space

New i18n keys (default + zh-CN + en-US): DragUpload.dragFolderTitle/Desc, DragUpload.dragMixedTitle/Desc.

Diagnostic logging: enable via localStorage.debug = 'lobe-client:drag-upload:*' in devtools.

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

Manual verification in the desktop app (bun dev under apps/desktop):

  1. Setup β€” open an agent with runtime mode = Local (desktop default), or a heterogeneous agent (e.g. Claude Code).
  2. Single folder drop β€” drag one folder into the conversation; expect overlay "Reference Folder", and a single @folder-name mention inserted at the cursor. No upload tray entry.
  3. Multiple folder drop β€” multi-select folders; expect mentions separated by spaces in drop order, followed by a trailing space.
  4. Single file drop β€” unchanged behavior; overlay "Upload Files", file appears in upload tray.
  5. Mixed drop β€” folder + file together; overlay "Reference Folder & Upload Files", folder becomes mention, file uploads.
  6. Send the message β€” markdown should contain <localFile name="..." path="..." isDirectory />; the agent's local-system tool should be able to act on it (subject to auditSafePaths).
  7. Fallback β€” with runtimeMode = cloud, dragging a folder reverts to the legacy recurse-and-upload behavior.

Unit tests:

bunx vitest run src/components/DragUploadZone/useLocalDragUpload.test.ts
bunx vitest run src/store/chat/slices/aiChat/actions/__tests__/conversationLifecycle.test.ts

πŸ“Έ Screenshots / Videos

Before After
Folder drop β†’ "Unsupported file type" upload warn Folder drop β†’ @folder mention at cursor; mixed drop splits cleanly to both pipelines

πŸ“ Additional Information

  • Only the agent Conversation route opts in (enableLocalFolderMention prop). Group, Home, PageEditor, AgentBuilder, AgentTaskManager, and ResourceManager DragUploadZone consumers keep their original behavior by default.
  • Out-of-scope drag (folder outside working directory): mention is still inserted; downstream auditSafePaths rejects with a clear error at tool-call time (per user-chosen UX A).
  • Drop target is still the entire conversation area (consistent with existing file upload zone); only the insertion target is the editor cursor.

When the agent's runtime mode is `local` (or it's a heterogeneous agent),
dragging a folder into the conversation now inserts a `<localFile path="..."
isDirectory />` mention at the editor cursor instead of recursively uploading
its contents. Mixed drops route folders to mentions and files to the existing
upload pipeline in drop order.

The drag overlay detects content kind on `dragenter` via `webkitGetAsEntry`
and swaps the title/desc/icon between "Upload Files", "Reference Folder", and
the mixed variant.

Also aligns the @ mention search and server-side local file materialization
gates with the same condition (`isLocalSystemEnabled || isHeterogeneous`)
since `lobe-local-system` plugin presence is already overridden in
toolEngineering β€” runtime mode is the only real gate.
@vercel

vercel Bot commented May 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment May 21, 2026 12:36pm

Request Review

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. feature:files File upload and knowledge base platform:desktop Desktop client labels May 21, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’‘ Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3af0f259d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with πŸ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +32 to +34
const editor = useChatStore.getState().mainInputEditor?.instance;
if (!editor) return;
insertLocalFolderMentions(editor, folders);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fallback to upload when editor instance is missing

If a folder is dropped before mainInputEditor is initialized (or when the input editor is absent), handleLocalFolders returns immediately and the folder is effectively discarded. In this flow, useLocalDragUpload has already partitioned the drop and will not run the legacy folder-upload path for those directory items, so users get neither a mention nor an upload. Please add a fallback (e.g., route folders back to upload handling) when mainInputEditor is unavailable.

Useful? React with πŸ‘Β / πŸ‘Ž.

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.65563% with 73 lines in your changes missing coverage. Please review.
βœ… Project coverage is 69.60%. Comparing base (9a4c8d5) to head (3af0f25).
⚠️ Report is 7 commits behind head on canary.

Additional details and impacted files
@@             Coverage Diff             @@
##           canary   #15071       +/-   ##
===========================================
- Coverage   89.20%   69.60%   -19.61%     
===========================================
  Files         778     3032     +2254     
  Lines       86433   292950   +206517     
  Branches     7083    30583    +23500     
===========================================
+ Hits        77104   203894   +126790     
- Misses       9164    88891    +79727     
  Partials      165      165               
Flag Coverage Ξ”
app 61.39% <51.65%> (?)
packages/agent-runtime 80.48% <ΓΈ> (ΓΈ)
packages/builtin-tool-lobe-agent 19.87% <ΓΈ> (ΓΈ)
packages/context-engine 84.07% <ΓΈ> (ΓΈ)
packages/conversation-flow 91.28% <ΓΈ> (ΓΈ)
packages/file-loaders 87.89% <ΓΈ> (ΓΈ)
packages/memory-user-memory 75.01% <ΓΈ> (ΓΈ)
packages/model-bank 99.99% <ΓΈ> (ΓΈ)
packages/model-runtime 83.56% <ΓΈ> (ΓΈ)
packages/prompts 71.60% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/types 35.16% <ΓΈ> (ΓΈ)
packages/utils 88.02% <ΓΈ> (ΓΈ)
packages/web-crawler 87.74% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.97% <100.00%> (βˆ…)
Services 54.66% <ΓΈ> (βˆ…)
Server 71.98% <ΓΈ> (βˆ…)
Libs 56.39% <ΓΈ> (βˆ…)
Utils 85.01% <ΓΈ> (-8.47%) ⬇️
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innei Innei merged commit b22ac0f into canary May 21, 2026
58 of 59 checks passed
@Innei Innei deleted the feat/drag-folder-as-mention branch May 21, 2026 13:09
arvinxx added a commit that referenced this pull request May 29, 2026
# πŸš€ LobeHub Release (20260528)

**Release Date:** May 28, 2026  
**Since v2.2.0:** 220 merged PRs Β· 15 contributors

> This cycle brings heterogeneous "platform agents" you can dispatch to
local or remote devices, a rebuilt onboarding flow, document-centric
chat, and a unified model-runtime error model β€” with new DeepSeek V4 and
Gemini 3.5 Flash support along the way.

---

## ✨ Highlights

- **More Hetero Agents (OpenClaw / Hermes)** β€” Create heterogeneous
agents and dispatch them to local or remote devices through the device
gateway, with an execution-target switcher in the composer and
persistent CLI sessions. (#15065, #15179, #15022)
- **iMessage on Desktop** β€” New iMessage setup and bridge on desktop,
plus bot attachments across every platform. (#15228, #15227, #15029)
- **Skills in the Composer** β€” Drag skill chips into chat, trigger
installed skills from the slash menu mid-line, and surface project-level
skills in the homogeneous agent runtime. (#15095, #15061, #15110)
- **New Models** β€” DeepSeek V4 Flash/Pro and Gemini 3.5 Flash across
providers, with thinking params for structured output and chat cost
estimates. (#15031, #15001, #15051, #14876)
- **Agent Runtime Observability** β€” OpenTelemetry GenAI semantic
conventions plus per-call generation tracing. (#15123, #15124)

---

## πŸ€– Agents & Heterogeneous Runtime

- **Platform agent creation** β€” OpenClaw/Hermes creation UI, device
guard, and remote dispatch backend. (#15065)
- **Execution-target switcher** β€” Pick local vs remote execution
directly in the composer; device-selection UX with actionable guidance.
(#15179, #15111)
- **CLI hetero dispatch** β€” OpenClaw/Hermes dispatch with persistent
sessions and a notify protocol. (#15022)
- **Gateway snapshot as source of truth** β€” Consume the gateway
`uiMessages` snapshot at step boundaries to keep chat state consistent.
(#15153, #15152)
- **Client sub-agent as a normal tool call** β€” Simplifies the sub-agent
execution path. (#15281)
- **Hermes agent chain** β€” Implements the Hermes agent chain logic.
(#15189)
- **Device registry** β€” TRPC endpoints to register, list, update, and
remove devices. (#15299)
- **Desktop device routing** β€” Route gateway agent runs through `lh
hetero exec`; restore `userId` in gateway dispatch and gate local-system
by execution target. (#15132, #15232)
- **Agent signals** β€” Anchor agent-signal receipts to messages and
isolate memory-agent messages into a child thread. (#14969, #14921)

---

## πŸš€ Onboarding

- **Simplified first screen** β€” Defer topic creation to first send.
(#15090)
- **Market Agent Picker** β€” Added as a classic onboarding step, with
template prefetch. (#14980, #15041)
- **Welcome guidance** β€” Show agent welcome guidance on first run.
(#15098)
- **Mobile** β€” Adapt agent onboarding UI and restore Classic-step
padding on mobile. (#15019, #15032)
- **Discovery** β€” Streamline discovery to a single profession question.
(#14987)
- **Analytics** β€” Track onboarding step events and create-agent modal
source. (#15133, #15028)

---

## πŸ“„ Documents, Pages & Knowledge

- **Thread chat in preview** β€” Embed thread chat in the document preview
portal. (#15216)
- **Non-markdown rendering** β€” Render non-markdown docs as a read-only
highlight. (#15272)
- **Multi-select** β€” Multi-select delete in the document tree. (#15125)
- **Page-agent streaming** β€” Preview `initPage` streaming arguments.
(#15039)
- **Per-agent topics** β€” Per-agent topic management page. (#15207)
- **Server-side category** β€” Derive document category server-side and
drop frontend predicates. (#15076)

---

## 🧩 Skills & Tools

- **Drag skill chips** β€” Drag skills into chat input and register
agent-document skills. (#15095)
- **Slash menu** β€” Installed skills appear in the slash menu with a
mid-line trigger. (#15061)
- **Project skills** β€” Recognize project-level skills in the homogeneous
agent runtime and surface them regardless of active device. (#15110,
#15177)
- **VFS archiving** β€” Archive oversized tool results to VFS instead of
truncating. (#15074)
- **@localfile mentions** β€” Drag folders into chat input as `@localFile`
mentions on desktop. (#15071)

---

## 🧠 Model Runtime & Providers

- **Error spec registry** β€” Unify error codes into a spec + pattern
registry, split `ProviderBizError` into finer codes, classify Cloud-only
codes via a tier digit, and add `DatabasePersistError`. (#15262, #15286,
#15278, #15279)
- **New models** β€” DeepSeek V4 Flash/Pro (opencode-go) and Gemini 3.5
Flash; DeepSeek V4 Pro on SiliconCloud. (#15031, #15001, #15017, #15267)
- **Structured output** β€” Thinking params for structured output, Bedrock
structured generation, and DeepSeek `generateObject` tool choice.
(#15051, #15174, #15054)
- **Cost** β€” Chat cost estimate support; preserve usage cost in custom
streams. (#14876, #15218)

---

## πŸ’¬ Chat & User Experience

- **Follow-up chips** β€” Extend follow-up chip suggestions to general
chat with scene-specific model config. (#15101, #14797)
- **Input drafts** β€” Persist unsent input drafts across tab switches and
prevent repeated draft restore. (#14992, #15024)
- **Command menu** β€” Order topic/message search by recency and promote
inline type filters. (#15094, #14986)
- **Zoom HUD** β€” Show a zoom-level HUD on Cmd +/βˆ’ and Cmd 0. (#15294)
- **Copy** β€” Unescape markdown escapes when copying user messages.
(#15253)

---

## πŸ–₯️ Desktop

- **App Nap fix** β€” Prevent App Nap from dropping the gateway WebSocket
during display sleep. (#14994)
- **File preview** β€” Preview `.cjs`/`.mjs`/no-extension files instead of
binary fallback and expand `~` when opening local files. (#15168,
#15284)
- **Cross-platform settings** β€” Open settings via main-window navigation
on Windows/Linux and restore the route after an update restart. (#15036,
#14922)
- **Token refresh** β€” Prevent frequent logout from token-refresh
retries. (#14928)

---

## πŸ“Š Observability

- **OTel GenAI** β€” Instrument Agent Runtime with OpenTelemetry GenAI
semantic conventions. (#15123)
- **Generation tracing** β€” Per-call `llm_generation_tracing` with a
pre-allocated tracingId and recordFeedback router. (#15124, #15146)
- **Error classification** β€” Persist `ERROR_CODE_SPECS` classification
on operation errors. (#15273)

---

## πŸ—ƒοΈ Database Migrations

- **Batch migrations** β€” Topic usage stats, push tokens,
`tasks.editor_data`, and document shares. (#15280)
- **Tracing & eval tables** β€” Add `llm_generation_tracing` and agent
eval experiment tables. (#15126)

> Self-hosted operators should run the database migration (`pnpm
db:migrate`, or restart with auto-migrate enabled) after upgrading. The
changes are additive and backwards-compatible.

---

## πŸ”’ Security & Reliability

- **Security:** Remove the `getPlaintextCred` tool to prevent plaintext
credential exposure. (#14998)
- **Security:** Prompt account selection for Google OAuth and add
`prompt=consent` to the OIDC authorization URL to fix missing refresh
tokens. (#15234, #15010)
- **Reliability:** Preserve streamed content across a mid-stream cancel.
(#15173)
- **Reliability:** Bound the Redis command timeout and configure the
Anthropic client timeout. (#15091, #15042)
- **Reliability:** Prevent infinite recursion in the assistant chain.
(#15288)

---

## πŸ‘₯ Contributors

Huge thanks to **15 contributors** who shipped **220 merged PRs** this
cycle.

@AnotiaWang Β· @sxjeru Β· @algojogacor Β· @hardy-one Β· @arvinxx Β· @Innei Β·
@tjx666 Β· @lijian Β· @AmAzing129 Β· @rdmclin2 Β· @neko Β· @cy948 Β·
@CanisMinor Β· @sudongyuer Β· @rivertwilight

Plus @lobehubbot and renovate[bot] for maintenance.

---

**Full Changelog**: v2.2.0...release/weekly-20260528
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:files File upload and knowledge base platform:desktop Desktop client size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant